Skip to content

[5/N] Fix clang-tidy warnings in torch/csrc/api/ #138389

Closed
cyyever wants to merge 1 commit intopytorch:mainfrom
cyyever:tidy_api6
Closed

[5/N] Fix clang-tidy warnings in torch/csrc/api/ #138389
cyyever wants to merge 1 commit intopytorch:mainfrom
cyyever:tidy_api6

Conversation

@cyyever
Copy link
Collaborator

@cyyever cyyever commented Oct 19, 2024 •
edited
Loading

Follows #138382

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 19, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138389

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 33e9c19 with merge base 1f349ee (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: cpp release notes category label Oct 19, 2024
@cyyever cyyever marked this pull request as draft October 19, 2024 15:02
@cyyever cyyever changed the title Tidy api6 [5/N] Fix clang-tidy warnings in torch/csrc/api/ Oct 20, 2024
@cyyever cyyever marked this pull request as ready for review October 20, 2024 10:06
Skylion007
Skylion007 reviewed Oct 20, 2024
View reviewed changes
@ezyang
Copy link
Contributor

ezyang commented Oct 20, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 20, 2024
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 20, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 20, 2024

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / macos-py3-arm64 / test (default, 2, 3, macos-m1-stable)

Details for Dev Infra team Raised by workflow job

@cyyever
Copy link
Collaborator Author

cyyever commented Oct 21, 2024

@pytorchmergebot merge -i

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 21, 2024

Merge started

Your change will be merged while ignoring the following 1 checks: trunk / macos-py3-arm64 / test (default, 2, 3, macos-m1-stable)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@cyyever cyyever deleted the tidy_api6 branch October 22, 2024 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 left review comments

@ezyang ezyang ezyang approved these changes

@pytorchmergebot pytorchmergebot Awaiting requested review from pytorchmergebot

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: cpp release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cyyever @ezyang @pytorchmergebot @Skylion007 @pytorchbot