Skip to content

[inductor] Remove LoopBody.reads,writes,other#135256

Closed
jansel wants to merge 2 commits intogh/jansel/386/basefrom
gh/jansel/386/head
Closed

[inductor] Remove LoopBody.reads,writes,other#135256
jansel wants to merge 2 commits intogh/jansel/386/basefrom
gh/jansel/386/head

Conversation

@jansel
Copy link
Contributor

@jansel jansel commented Sep 5, 2024 •
edited
Loading

@jansel
Update
859c66e 
[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 5, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/135256

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 17fa37f with merge base 58f2477 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@jansel jansel mentioned this pull request Sep 5, 2024
Closed
@jansel
Update
17fa37f 
[ghstack-poisoned]
This was referenced Sep 6, 2024
Closed
Closed
@jansel jansel added the topic: not user facing topic category label Sep 6, 2024
@jansel jansel mentioned this pull request Sep 6, 2024
Closed
@jansel jansel requested a review from oulgen September 6, 2024 03:26
@jansel jansel marked this pull request as ready for review September 6, 2024 03:26
@jansel jansel added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 6, 2024
@jansel
Copy link
Contributor Author

jansel commented Sep 6, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 6, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@laithsakka
Copy link
Contributor

laithsakka commented Sep 6, 2024 •
edited
Loading

this comment enhanced the following benchmark runtime @jansel thanks for the contrubution


{   "add_loop_eager": -5.4302010857279,  
 "add_loop_inductor": -3.0461083536991,  
  "basic_modules_ListOfLinears_inductor": -5.6625260802442,   
  "basic_modules_ModuleComparison_eager": -1.5382655757287,  
   "basic_modules_ModuleComparison_inductor": -6.0396226128571,   
   "basic_modules_ModuleForwardHasGraphBreak_inductor": -3.4973499780682,   
   "basic_modules_SequentialWithDuplicatedModule_inductor": -6.5934134523313,  
    "sum_floordiv_regression": -2.7588639354036 
}

@ezyang ezyang mentioned this pull request Sep 7, 2024
Closed
enter-ctrl9 pushed a commit to enter-ctrl9/pytorch11 that referenced this pull request Sep 15, 2024
@jansel
[inductor] Remove LoopBody.reads,writes,other
bbac0f0 
ghstack-source-id: 37ad8b8
Pull Request resolved: pytorch/pytorch#135256
Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Sep 20, 2024
@jansel @Chao1Han
[inductor] Remove LoopBody.reads,writes,other (pytorch#135256)
5eaffc4 
Pull Request resolved: pytorch#135256
Approved by: https://github.com/oulgen
ghstack dependencies: pytorch#135070, pytorch#135076, pytorch#135082, pytorch#135084, pytorch#135079, pytorch#135235
@github-actions github-actions bot deleted the gh/jansel/386/head branch October 7, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oulgen oulgen oulgen approved these changes

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jansel @pytorchmergebot @laithsakka @oulgen