[inductor] Remove ReadWrites.op_counts#135306
Closed
jansel wants to merge 5 commits intogh/jansel/389/basefrom
Closed
[inductor] Remove ReadWrites.op_counts#135306jansel wants to merge 5 commits intogh/jansel/389/basefrom
jansel wants to merge 5 commits intogh/jansel/389/basefrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/135306
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit bba6e29 with merge base e72ed47 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Sep 6, 2024
This was referenced Sep 7, 2024
oulgen
approved these changes
Sep 8, 2024
pytorchmergebot
pushed a commit
that referenced
this pull request
Sep 8, 2024
Before (bottom of stack):  After (this PR):  Pull Request resolved: #135377 Approved by: https://github.com/oulgen ghstack dependencies: #135286, #135306
pytorchmergebot
pushed a commit
that referenced
this pull request
Sep 8, 2024
Might be a small compile time improvement since we remove a call to extract_read_writes(). Pull Request resolved: #135400 Approved by: https://github.com/oulgen ghstack dependencies: #135286, #135306, #135377
pytorchmergebot
pushed a commit
that referenced
this pull request
Sep 8, 2024
Before this we would take multiple passes over the body of each IRNode as we did lowering. This combines most analysis into `OpCounterCSE` so it can be done in a single pass. Before:  After:  This stack:  Pull Request resolved: #135412 Approved by: https://github.com/oulgen ghstack dependencies: #135286, #135306, #135377, #135400
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Sep 20, 2024
This was (almost) unused. Pull Request resolved: pytorch#135306 Approved by: https://github.com/oulgen ghstack dependencies: pytorch#135286
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Sep 20, 2024
…#135377) Before (bottom of stack):  After (this PR):  Pull Request resolved: pytorch#135377 Approved by: https://github.com/oulgen ghstack dependencies: pytorch#135286, pytorch#135306
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Sep 20, 2024
Might be a small compile time improvement since we remove a call to extract_read_writes(). Pull Request resolved: pytorch#135400 Approved by: https://github.com/oulgen ghstack dependencies: pytorch#135286, pytorch#135306, pytorch#135377
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Sep 20, 2024
Before this we would take multiple passes over the body of each IRNode as we did lowering. This combines most analysis into `OpCounterCSE` so it can be done in a single pass. Before:  After:  This stack:  Pull Request resolved: pytorch#135412 Approved by: https://github.com/oulgen ghstack dependencies: pytorch#135286, pytorch#135306, pytorch#135377, pytorch#135400
KnAwnime
pushed a commit
to KnAwnime/Biblioteka
that referenced
this pull request
Oct 16, 2024
ghstack-source-id: 3a3e3a1 Pull Request resolved: pytorch/pytorch#135306
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This was (almost) unused.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang