[fx] Bypass custom __setattr__ in Node.__init__ by jansel · Pull Request #135079 · pytorch/pytorch

jansel · 2024-09-04T00:45:21Z

Stack from ghstack (oldest at bottom):

Before:

After:

[ghstack-poisoned]

pytorch-bot · 2024-09-04T00:45:24Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/135079

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 5613da3 with merge base 58f2477 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[ghstack-poisoned]

ghstack-source-id: 41affa0 Pull Request resolved: #135079

[ghstack-poisoned]

pytorchmergebot · 2024-09-10T03:01:35Z

Reverting PR 135079 failed

Reason: Command git -C /home/runner/work/pytorch/pytorch revert --no-edit 7ffb3b201c86f6a84e069a4cacf939183b16ebed returned non-zero exit code 1

Auto-merging torch/_inductor/ir.py
CONFLICT (content): Merge conflict in torch/_inductor/ir.py
error: could not revert 7ffb3b201c... [inductor] Remove LoopBody.reads,writes,other (#135256)
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git revert --continue".
hint: You can instead skip this commit with "git revert --skip".
hint: To abort and get back to the state before "git revert",
hint: run "git revert --abort".
hint: Disable this message with "git config advice.mergeConflict false"

Details for Dev Infra team

Raised by workflow job

This reverts commit 66da3b3.

@jansel

…135562) This reverts commit 66da3b3. #135079 breaks internal tests and needs to be reverted. Revert with mergebot doesn't work as this PR is technically part of the stack, but, according to @jansel, it should be possible to revert it individually. Pull Request resolved: #135562 Approved by: https://github.com/jansel, https://github.com/seemethere

Relands pytorch#135079 whcih was reverted by pytorch#135562 I broke this up into three parts to test internally.

Relands #135079 whcih was reverted by #135562 I broke this up into three parts to test internally. Pull Request resolved: #135733 Approved by: https://github.com/oulgen

Relands #135079 whcih was reverted by #135562 I broke this up into three parts to test internally. Pull Request resolved: #135735 Approved by: https://github.com/oulgen

Relands pytorch#135079 whcih was reverted by pytorch#135562 I broke this up into three parts to test internally.

@jansel

#135625) Revert "[fx] Bypass custom __setattr__ in Node.__init__ (#135079)" (#135562) This reverts commit 66da3b3. #135079 breaks internal tests and needs to be reverted. Revert with mergebot doesn't work as this PR is technically part of the stack, but, according to @jansel, it should be possible to revert it individually. Pull Request resolved: #135562 Approved by: https://github.com/jansel, https://github.com/seemethere Co-authored-by: Ivan Zaitsev <ivanzaitsev@fb.com>

Before: ![image](https://github.com/user-attachments/assets/5f0a6ae6-6049-44d0-b5f2-a549a23ad97f) After: ![image](https://github.com/user-attachments/assets/51c9f91b-f8a0-4043-8362-65813feec823) Pull Request resolved: pytorch#135079 Approved by: https://github.com/oulgen ghstack dependencies: pytorch#135070, pytorch#135076, pytorch#135082, pytorch#135084

This is roughly a 7% speedup in inductor compile time for hf_Bert_large. The time spent in `LoopBody.__init__` improves from 15% to 8% of `fx_codegen_and_compile`. Before ![image](https://github.com/user-attachments/assets/7de0f28e-35bd-472f-b4be-b52733d2a85c) After ![image](https://github.com/user-attachments/assets/5f0cf11a-43c5-43ae-b13c-f32383a75a7f) Overall ![image](https://github.com/user-attachments/assets/6a369d8c-fb5e-4ad2-9504-0fc745ad6568) Pull Request resolved: pytorch#135235 Approved by: https://github.com/oulgen ghstack dependencies: pytorch#135070, pytorch#135076, pytorch#135082, pytorch#135084, pytorch#135079

Pull Request resolved: pytorch#135256 Approved by: https://github.com/oulgen ghstack dependencies: pytorch#135070, pytorch#135076, pytorch#135082, pytorch#135084, pytorch#135079, pytorch#135235

@jansel

…)" (pytorch#135562) This reverts commit 66da3b3. pytorch#135079 breaks internal tests and needs to be reverted. Revert with mergebot doesn't work as this PR is technically part of the stack, but, according to @jansel, it should be possible to revert it individually. Pull Request resolved: pytorch#135562 Approved by: https://github.com/jansel, https://github.com/seemethere

…135733) Relands pytorch#135079 whcih was reverted by pytorch#135562 I broke this up into three parts to test internally. Pull Request resolved: pytorch#135733 Approved by: https://github.com/oulgen

…135735) Relands pytorch#135079 whcih was reverted by pytorch#135562 I broke this up into three parts to test internally. Pull Request resolved: pytorch#135735 Approved by: https://github.com/oulgen

Update

1c1b7c8

[ghstack-poisoned]

This was referenced Sep 4, 2024

[inductor] Improve compile time regression from MemoryDep.normalize #135070

Closed

[fx] Compile time optimization in Node.__update_args_kwargs #135076

Closed

pytorch-bot bot added the release notes: fx release notes category label Sep 4, 2024

This was referenced Sep 4, 2024

[fx] Don't use generators in map_aggregate #135082

Closed

[debug] Add helper to run cProfile on a function #135084

Closed

jansel added 3 commits September 3, 2024 19:28

Update

ed9e356

[ghstack-poisoned]

Update

727a9fc

[ghstack-poisoned]

Update

55c5e77

[ghstack-poisoned]

jansel marked this pull request as draft September 4, 2024 21:45

Update

e1d082b

[ghstack-poisoned]

Update

67c9f71

[ghstack-poisoned]

Update

8d3b1ff

[ghstack-poisoned]

Update

a7d4c97

[ghstack-poisoned]

jansel added a commit that referenced this pull request Sep 4, 2024

[fx] Bypass custom __setattr__ in Node.__init__

7f4683f

ghstack-source-id: 41affa0 Pull Request resolved: #135079

This was referenced Sep 5, 2024

[inductor] Skip retracing an existing LoopBody #135235

Closed

[inductor] Remove LoopBody.reads,writes,other #135256

Closed

[inductor] Move LoopBody to its own file #135257

Closed

Update

5613da3

[ghstack-poisoned]

This was referenced Sep 6, 2024

[inductor] Refactor LoopBody.memory_usage #135286

Closed

[inductor] Remove ReadWrites.op_counts #135306

Closed

jansel requested a review from oulgen September 6, 2024 03:22

jansel marked this pull request as ready for review September 6, 2024 03:22

oulgen approved these changes Sep 6, 2024

View reviewed changes

izaitsevfb added a commit that referenced this pull request Sep 10, 2024

Revert "[fx] Bypass custom __setattr__ in Node.__init__ (#135079)"

e9e4212

This reverts commit 66da3b3.

izaitsevfb mentioned this pull request Sep 10, 2024

Revert "[fx] Bypass custom __setattr__ in Node.__init__ (#135079)" #135562

Closed

kit1980 mentioned this pull request Sep 10, 2024

Revert "[fx] Bypass custom __setattr__ in Node.__init__ (#135079)" (#… #135625

Merged

jansel added a commit to jansel/pytorch that referenced this pull request Sep 11, 2024

[reland 3/3][fx] Bypass custom __setattr__ in Node.__init__

589c4fb

Relands pytorch#135079 whcih was reverted by pytorch#135562 I broke this up into three parts to test internally.

This was referenced Sep 11, 2024

[reland 1/3][fx] Bypass custom __setattr__ in Node.__init__ #135733

Closed

[reland 2/3][fx] Bypass custom __setattr__ in Node.__init__ #135734

Closed

[reland 3/3][fx] Bypass custom __setattr__ in Node.__init__ #135735

Closed

jansel added a commit to jansel/pytorch that referenced this pull request Sep 12, 2024

[reland 2/3][fx] Bypass custom __setattr__ in Node.__init__

5f01be0

Relands pytorch#135079 whcih was reverted by pytorch#135562 I broke this up into three parts to test internally.

github-actions bot deleted the gh/jansel/382/head branch October 12, 2024 02:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[fx] Bypass custom setattr in Node.init#135079

[fx] Bypass custom setattr in Node.init#135079
jansel wants to merge 9 commits intogh/jansel/382/basefrom
gh/jansel/382/head

jansel commented Sep 4, 2024 •

edited

Loading

Uh oh!

pytorch-bot bot commented Sep 4, 2024 •

edited

Loading

Uh oh!

pytorchmergebot commented Sep 10, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

jansel commented Sep 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Sep 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/135079

✅ No Failures

Uh oh!

pytorchmergebot commented Sep 10, 2024

Reverting PR 135079 failed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jansel commented Sep 4, 2024 •

edited

Loading

pytorch-bot bot commented Sep 4, 2024 •

edited

Loading