[Dynamo][autograd.Function] Trace fwd graph under no_grad mode#134872
Closed
yanboliang wants to merge 1 commit intogh/yanboliang/31/basefrom
Closed
[Dynamo][autograd.Function] Trace fwd graph under no_grad mode#134872yanboliang wants to merge 1 commit intogh/yanboliang/31/basefrom
yanboliang wants to merge 1 commit intogh/yanboliang/31/basefrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/134872
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit aca4d6b with merge base de35d30 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
zou3519
approved these changes
Aug 30, 2024
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Sep 20, 2024
…ch#134872) Fixes pytorch#134820 Pull Request resolved: pytorch#134872 Approved by: https://github.com/zou3519
yanboliang
added a commit
to yanboliang/pytorch
that referenced
this pull request
Sep 26, 2024
This reverts commit aca4d6b.
kit1980
pushed a commit
that referenced
this pull request
Sep 26, 2024
mryszt
pushed a commit
to HabanaAI/pytorch-fork
that referenced
this pull request
Oct 14, 2024
Cherry-pick: pytorch#134872 Change-Id: I382a8317e175cc25f6cc95aaebe10e2e0d49ee18
zou3519
added a commit
that referenced
this pull request
Oct 14, 2024
…no_grad mode (#134872)"" This reverts commit e688b78. We're reverting this because: 1) The original PR (#134872) fixed a bug but caused another one. The assessment is that the bug it caused is worse than the bug it fixed. 2) it was reverted on the release 2.5 branch, so we want to prevent divergence 3) The original author is out-of-office for a while so we don't want the divergence to wait until they're back [ghstack-poisoned]
zou3519
added a commit
that referenced
this pull request
Oct 14, 2024
#134872)" This reverts commit e688b78. We're reverting this because: 1) The original PR (#134872) fixed a bug but caused another one. The assessment is that the bug it caused is worse than the bug it fixed. 2) it was reverted on the release 2.5 branch, so we want to prevent divergence 3) The original author is out-of-office for a while so we don't want the divergence to wait until they're back ghstack-source-id: 39ed09a Pull Request resolved: #137891
mryszt
pushed a commit
to HabanaAI/pytorch-fork
that referenced
this pull request
Oct 14, 2024
Cherry-pick: pytorch#134872 Change-Id: I382a8317e175cc25f6cc95aaebe10e2e0d49ee18
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 14, 2024
#134872)" (#137891) This reverts commit e688b78. We're reverting this because: 1) The original PR (#134872) fixed a bug but caused another one. The assessment is that the bug it caused is worse than the bug it fixed. 2) it was reverted on the release 2.5 branch, so we want to prevent divergence 3) The original author is out-of-office for a while so we don't want the divergence to wait until they're back Pull Request resolved: #137891 Approved by: https://github.com/Skylion007
aostrowski-hbn
pushed a commit
to HabanaAI/pytorch-fork
that referenced
this pull request
Oct 16, 2024
Cherry-pick: pytorch#134872 Change-Id: I382a8317e175cc25f6cc95aaebe10e2e0d49ee18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Fixes #134820
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @rec