Revert "[Dynamo][autograd.Function] Trace fwd graph under no_grad mode (#134872)"#137891
Closed
zou3519 wants to merge 2 commits intogh/zou3519/1079/basefrom
Closed
Revert "[Dynamo][autograd.Function] Trace fwd graph under no_grad mode (#134872)"#137891zou3519 wants to merge 2 commits intogh/zou3519/1079/basefrom
zou3519 wants to merge 2 commits intogh/zou3519/1079/basefrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137891
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 2 Unrelated FailuresAs of commit 33ba0d3 with merge base 41977a0 ( NEW FAILURE - The following job has failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
…no_grad mode (#134872)"" This reverts commit e688b78. We're reverting this because: 1) The original PR (#134872) fixed a bug but caused another one. The assessment is that the bug it caused is worse than the bug it fixed. 2) it was reverted on the release 2.5 branch, so we want to prevent divergence 3) The original author is out-of-office for a while so we don't want the divergence to wait until they're back [ghstack-poisoned]
zou3519
added a commit
that referenced
this pull request
Oct 14, 2024
#134872)" This reverts commit e688b78. We're reverting this because: 1) The original PR (#134872) fixed a bug but caused another one. The assessment is that the bug it caused is worse than the bug it fixed. 2) it was reverted on the release 2.5 branch, so we want to prevent divergence 3) The original author is out-of-office for a while so we don't want the divergence to wait until they're back ghstack-source-id: 39ed09a Pull Request resolved: #137891
Skylion007
approved these changes
Oct 14, 2024
Contributor
Author
|
@pytorchbot merge -f "unrelated failure" |
Collaborator
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This reverts commit e688b78.
We're reverting this because:
assessment is that the bug it caused is worse than the bug it fixed.
divergence
divergence to wait until they're back
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @rec