Skip to content

Revert "Trace fwd graph under no_grad mode #134872"#136734

Merged
kit1980 merged 1 commit intopytorch:release/2.5from
yanboliang:grad-2.5
Sep 26, 2024
Merged

Revert "Trace fwd graph under no_grad mode #134872"#136734
kit1980 merged 1 commit intopytorch:release/2.5from
yanboliang:grad-2.5

Conversation

@yanboliang
Copy link
Contributor

@yanboliang yanboliang commented Sep 26, 2024

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 26, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136734

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 151 Cancelled Jobs

As of commit cf38071 with merge base b7eb725 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@yanboliang yanboliang added ciflow/trunk Trigger trunk jobs on your pull request topic: not user facing topic category labels Sep 26, 2024
@yanboliang yanboliang requested a review from zou3519 September 26, 2024 05:00
@kit1980
Copy link
Contributor

kit1980 commented Sep 26, 2024

Can you explain a bit more why is this needed?

@yanboliang
Copy link
Contributor Author

@kit1980 The original PR (#134872) was going to fix a bug, but we found it's not a clean fix, as it involves another critical bug (#129963). So we decide to revert that PR in the 2.5 release branch, and we are working on the proper fix at #136184, which may need more time.

@kit1980 kit1980 merged commit 1715708 into pytorch:release/2.5 Sep 26, 2024
@yanboliang yanboliang deleted the grad-2.5 branch September 26, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request module: dynamo topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants