Replace direct use of int32_t with an alias DeviceIndex#13019
Closed
ezyang wants to merge 1 commit intoexport-D10513246from
Closed
Replace direct use of int32_t with an alias DeviceIndex#13019ezyang wants to merge 1 commit intoexport-D10513246from
ezyang wants to merge 1 commit intoexport-D10513246from
Conversation
Differential Revision: D10520295 Differential Version: 61458546
This was referenced Oct 23, 2018
zou3519
approved these changes
Oct 24, 2018
soumith
approved these changes
Oct 24, 2018
Contributor
|
Is there a reason why the native_functions get_device returns an int64_t? |
Contributor
Author
|
@zou3519 It's probably because in our API we generally return |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Pull Request resolved: pytorch#13019 It just makes the semantic meaning of the int32_t a little bit clearer. Reviewed By: zou3519 Differential Revision: D10520295 fbshipit-source-id: 45b0bd1b6afddee17072b628d8e9b87d7c86e501
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack:
:white_circle: #12995 Move Device and DeviceType to c10 💛
:black_circle: #13019 Replace direct use of int32_t with an alias DeviceIndex 💛
:white_circle: #13021 Delete default constructor from CUDAStream. 💛
It just makes the semantic meaning of the int32_t a little
bit clearer.
Differential Revision: D10520295