Closed
Conversation
Differential Revision: D10513246 Differential Version: 61419882
Differential Revision: D10513246 Differential Version: 61420227
li-roy
approved these changes
Oct 23, 2018
Contributor
li-roy
left a comment
There was a problem hiding this comment.
looks good, please fix builds :)
Yangqing
approved these changes
Oct 23, 2018
Contributor
Yangqing
left a comment
There was a problem hiding this comment.
Thanks so much! Approved with minor comments.
| @@ -1,2 +1,2 @@ | |||
| #pragma once | |||
| #include <ATen/core/Device.h> | |||
| #include <c10/Device.h> | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| namespace c10 { | ||
|
|
||
| std::string DeviceTypeName(at::DeviceType d, bool lower_case) { | ||
| std::string DeviceTypeName(DeviceType d, bool lower_case) { |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| }; | ||
| } // namespace std | ||
|
|
||
| // TODO: Remove me when we get a global c10 namespace using in at |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Yangqing
reviewed
Oct 23, 2018
|
|
||
| // TODO: Remove when we add global namespace include | ||
| namespace at { | ||
| using c10::Device; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Differential Revision: D10513246 Differential Version: 61434145
Differential Revision: D10513246 Differential Version: 61443861
This was referenced Oct 23, 2018
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Oct 24, 2018
Summary: Pull Request resolved: pytorch/pytorch#12995 Reviewed By: Yangqing Differential Revision: D10513246 fbshipit-source-id: 0c6d52e09166d7e8a786c1a0e21685ec9c35b12a
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Pull Request resolved: pytorch#12995 Reviewed By: Yangqing Differential Revision: D10513246 fbshipit-source-id: 0c6d52e09166d7e8a786c1a0e21685ec9c35b12a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack:
:black_circle: #12995 Move Device and DeviceType to c10 💛
:white_circle: #13019 Replace direct use of int32_t with an alias DeviceIndex 💛
:white_circle: #13021 Delete default constructor from CUDAStream. 💛
Differential Revision: D10513246