Delete default constructor from CUDAStream.#13021
Closed
ezyang wants to merge 20 commits intoexport-D10853224from
Closed
Delete default constructor from CUDAStream.#13021ezyang wants to merge 20 commits intoexport-D10853224from
ezyang wants to merge 20 commits intoexport-D10853224from
Conversation
Differential Revision: D10513246 Differential Version: 61419882
Differential Revision: D10513246 Differential Version: 61420227
Differential Revision: D10513246 Differential Version: 61434145
Differential Revision: D10513246 Differential Version: 61443861
Differential Revision: D10520295 Differential Version: 61458546
Differential Revision: D10520421 Differential Version: 61459119
This was referenced Oct 23, 2018
Differential Revision: D10520421 Differential Version: 61459533
Differential Revision: D10520421 Differential Version: 61461399
Contributor
Author
|
This is annoying for client code, I'm not going to do it. |
Contributor
Author
|
Nevermind, the call sites must die |
Differential Revision: D10520421 Differential Version: 61510016
Differential Revision: D10528061 Differential Version: 61512798
Differential Revision: D10520421 Differential Version: 61514357
Differential Revision: D10520421 Differential Version: 61514849
Differential Revision: D10520421 Differential Version: 61532957
Contributor
Author
|
This appears to have broken NCCL. |
Differential Revision: D10520421 Differential Version: 61650165
Differential Revision: D10520421 Differential Version: 61651201
Differential Revision: D10520421 Differential Version: 61671479
Differential Revision: D10520421 Differential Version: 61686215
Differential Revision: D10520421 Differential Version: 61786871
teng-li
reviewed
Oct 26, 2018
Contributor
teng-li
left a comment
There was a problem hiding this comment.
Spoke offline, please fix these push_backs
Differential Revision: D10520421 Differential Version: 61828001
Differential Revision: D10520421 Differential Version: 61911845
Contributor
Author
|
@teng-li Now that the move constructor is fixed in HEAD, |
gchanan
approved these changes
Oct 29, 2018
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Oct 29, 2018
Summary: Pull Request resolved: pytorch/pytorch#13021 Let's make nullptr CUDAStream an illegal state. Reviewed By: gchanan Differential Revision: D10520421 fbshipit-source-id: 723c1f5130b2c92ec97411a958707fac4a90173f
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Pull Request resolved: pytorch#13021 Let's make nullptr CUDAStream an illegal state. Reviewed By: gchanan Differential Revision: D10520421 fbshipit-source-id: 723c1f5130b2c92ec97411a958707fac4a90173f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack:
:white_circle: #13125 Rewrite THPUtils_PySequence_to_CUDAStreamList to return vector<optional> 💛
:black_circle: #13021 Delete default constructor from CUDAStream. 💛
:white_circle: #13133 Add c10::Stream, make at::cuda::CUDAStream use it. 💛
:white_circle: #13232 Delete DeviceGuard(int64_t) constructor. 💛
Let's make nullptr CUDAStream an illegal state.
Differential Revision: D10520421