Closed
Conversation
Differential Revision: D9623916 Differential Version: 56705898
Differential Revision: D9623916 Differential Version: 56858422
Differential Revision: D9644700 Differential Version: 56870160
Differential Revision: D9623916 Differential Version: 56900314
Differential Revision: D9644700 Differential Version: 56900331
Differential Revision: D9652088 Differential Version: 56917655
Differential Revision: D9652088 Differential Version: 56918713
Differential Revision: D9652089 Differential Version: 56918714
Differential Revision: D9623916 Differential Version: 56982469
Differential Revision: D9644700 Differential Version: 56982494
Differential Revision: D9652088 Differential Version: 56982465
Differential Revision: D9652089 Differential Version: 56982470
Differential Revision: D9663476 Differential Version: 56982467
Differential Revision: D9623916 Differential Version: 57101548
Differential Revision: D9644700 Differential Version: 57101652
Differential Revision: D9652088 Differential Version: 57101545
Differential Revision: D9652089 Differential Version: 57101550
Differential Revision: D9663476 Differential Version: 57101556
Differential Revision: D9623916 Differential Version: 57135223
Differential Revision: D9644700 Differential Version: 57135224
Differential Revision: D9652088 Differential Version: 57135218
Differential Revision: D9652089 Differential Version: 57135219
Differential Revision: D9663476 Differential Version: 57135226
Differential Revision: D9694327 Differential Version: 57135227
Differential Revision: D9694326 Differential Version: 57135216
Differential Revision: D9694918 Differential Version: 57140103
Differential Revision: D9623916 Differential Version: 57214033
Differential Revision: D9644700 Differential Version: 57214023
Differential Revision: D9652088 Differential Version: 57214005
Differential Revision: D9652089 Differential Version: 57214030
Differential Revision: D9763422 Differential Version: 59872623
Differential Revision: D9763422 Differential Version: 59874179
Differential Revision: D9763422 Differential Version: 59875467
Differential Revision: D9763422 Differential Version: 59876674
Differential Revision: D9763422 Differential Version: 59879239
Differential Revision: D9763422 Differential Version: 59882454
Differential Revision: D9763422 Differential Version: 59883487
Differential Revision: D9763422 Differential Version: 59886110
Differential Revision: D9763422 Differential Version: 59890579
Differential Revision: D9763422 Differential Version: 59898430
Differential Revision: D9763422 Differential Version: 59902014
Differential Revision: D9763422 Differential Version: 59910282
Differential Revision: D10139933 Differential Version: 59930646
Differential Revision: D10139935 Differential Version: 59930643
Differential Revision: D10139934 Differential Version: 59930644
Differential Revision: D10184117 Differential Version: 59930642
Differential Revision: D10139933 Differential Version: 60109134
Differential Revision: D10139935 Differential Version: 60109133
Differential Revision: D10139934 Differential Version: 60109128
Differential Revision: D10184117 Differential Version: 60109130
Differential Revision: D10184117 Differential Version: 60766870
Differential Revision: D10184117 Differential Version: 60767839
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Oct 17, 2018
Summary: Pull Request resolved: pytorch/pytorch#12306 In a future diff, I'm going to introduce non-placement constructor and destructor to TypeMeta. To make it less ambigous, this diff is first renaming the existing ones to PlacementXXX. Reviewed By: dzhulgakov Differential Revision: D10184117 fbshipit-source-id: 119120ebc718048bdc1d66e0cc4d6a7840e666a4
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Pull Request resolved: pytorch#12306 In a future diff, I'm going to introduce non-placement constructor and destructor to TypeMeta. To make it less ambigous, this diff is first renaming the existing ones to PlacementXXX. Reviewed By: dzhulgakov Differential Revision: D10184117 fbshipit-source-id: 119120ebc718048bdc1d66e0cc4d6a7840e666a4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack:
:black_circle: #12306 Rename TypeMeta function pointers 💚
:white_circle: #12307 Add TypeMeta::New/Delete 💚
:white_circle: #11500 Use TypeMeta::dtor() instead of Blob::DestroyCall 💚
:white_circle: #11925 Serialization takes pointers instead of Blob 💚
:white_circle: #11926 Remove Blob::ShareExternal from serialization 💚
In a future diff, I'm going to introduce non-placement constructor and destructor to TypeMeta.
To make it less ambigous, this diff is first renaming the existing ones to PlacementXXX.
Differential Revision: D10184117