Serialization takes pointers instead of Blob#11925
Closed
Serialization takes pointers instead of Blob#11925
Conversation
Differential Revision: D9652089 Differential Version: 57214030
Differential Revision: D9663476 Differential Version: 57214029
Differential Revision: D9694327 Differential Version: 57214021
Differential Revision: D9694326 Differential Version: 57214006
Differential Revision: D9694918 Differential Version: 57214017
Differential Revision: D9728631 Differential Version: 57253417
Differential Revision: D9731326 Differential Version: 57268332
Differential Revision: D9756666 Differential Version: 57416315
Differential Revision: D9728631 Differential Version: 57416732
Differential Revision: D9731326 Differential Version: 57416729
Differential Revision: D9756666 Differential Version: 57416734
Differential Revision: D9694327 Differential Version: 57417174
Differential Revision: D9694326 Differential Version: 57417173
Differential Revision: D9694918 Differential Version: 57417171
Differential Revision: D9728631 Differential Version: 57417176
Differential Revision: D9731326 Differential Version: 57417172
Differential Revision: D9756666 Differential Version: 57417177
Differential Revision: D9694327 Differential Version: 57452249
Differential Revision: D9694326 Differential Version: 57452245
Differential Revision: D9694918 Differential Version: 57452247
Differential Revision: D9728631 Differential Version: 57452248
Differential Revision: D9731326 Differential Version: 57452243
Differential Revision: D9756666 Differential Version: 57452242
Differential Revision: D9763423 Differential Version: 57452241
Differential Revision: D9763424 Differential Version: 57452246
Differential Revision: D9763422 Differential Version: 57452244
Differential Revision: D9778043 Differential Version: 57535396
Differential Revision: D9694327 Differential Version: 57535399
Differential Revision: D9778042 Differential Version: 57535402
Differential Revision: D9694326 Differential Version: 5753540
Differential Revision: D10139934 Differential Version: 59930644
Differential Revision: D10184117 Differential Version: 59930642
Differential Revision: D10184116 Differential Version: 59930641
Differential Revision: D9763423 Differential Version: 59930640
Differential Revision: D9884177 Differential Version: 59930647
Differential Revision: D10139933 Differential Version: 60109134
Differential Revision: D10139935 Differential Version: 60109133
Differential Revision: D10139934 Differential Version: 60109128
Differential Revision: D10184117 Differential Version: 60109130
Differential Revision: D10184116 Differential Version: 60109131
Differential Revision: D9763423 Differential Version: 60109136
Differential Revision: D9884177 Differential Version: 60109132
ezyang
approved these changes
Oct 13, 2018
Differential Revision: D10184117 Differential Version: 60766870
Differential Revision: D10184116 Differential Version: 60766869
Differential Revision: D9763423 Differential Version: 60766875
Differential Revision: D9884177 Differential Version: 60766871
Differential Revision: D10184117 Differential Version: 60767839
Differential Revision: D10184116 Differential Version: 60767838
Differential Revision: D9763423 Differential Version: 60767852
Differential Revision: D9884177 Differential Version: 60767853
Differential Revision: D10184116 Differential Version: 60887305
Differential Revision: D9763423 Differential Version: 60887304
Differential Revision: D9884177 Differential Version: 60887303
Differential Revision: D9884177 Differential Version: 60898391
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack:
:black_circle: #11925 Serialization takes pointers instead of Blob 💚
:white_circle: #11926 Remove Blob::ShareExternal from serialization 💚
This is step 1 in the refactoring to remove Blob::ShareExternal(), i.e. Blob would then always own its contents.
ShareExternal() is for example used to pass non-owning blobs to serialization. This diff prepares removing that.
Differential Revision: D9884177