Remove Blob::ShareExternal from serialization#11926
Closed
smessmer wants to merge 17 commits intoexport-D9884177from
Closed
Remove Blob::ShareExternal from serialization#11926smessmer wants to merge 17 commits intoexport-D9884177from
smessmer wants to merge 17 commits intoexport-D9884177from
Conversation
Differential Revision: D9884563 Differential Version: 58501790
This was referenced Sep 21, 2018
Closed
ezyang
approved these changes
Sep 24, 2018
Contributor
ezyang
left a comment
There was a problem hiding this comment.
(BTW, this code looks really slow...)
Differential Revision: D9884563 Differential Version: 58691280
Differential Revision: D9884563 Differential Version: 58749268
Differential Revision: D9884563 Differential Version: 58780868
Differential Revision: D9884563 Differential Version: 58857360
Differential Revision: D9884563 Differential Version: 58899985
Differential Revision: D9884563 Differential Version: 58901377
Differential Revision: D9884563 Differential Version: 59384179
Closed
Differential Revision: D9884563 Differential Version: 59638707
This was referenced Oct 3, 2018
Differential Revision: D9884563 Differential Version: 59644401
Differential Revision: D9884563 Differential Version: 59750308
Differential Revision: D9884563 Differential Version: 59930645
Differential Revision: D9884563 Differential Version: 60109129
Differential Revision: D9884563 Differential Version: 60766873
Differential Revision: D9884563 Differential Version: 60767851
Differential Revision: D9884563 Differential Version: 60887306
Differential Revision: D9884563 Differential Version: 60898408
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack:
:white_circle: #11925 Serialization takes pointers instead of Blob 💚
:black_circle: #11926 Remove Blob::ShareExternal from serialization 💚
With the preparation work of diffs stacked below, we're now able to remove this call to Blob::ShareExternal(),
preparing for removing that function from Blob,
Differential Revision: D9884563