Skip to content

[dynamo] Skip some tests using scipy.kstest#116263

Closed
peterbell10 wants to merge 3 commits intogh/peterbell10/676/basefrom
gh/peterbell10/676/head
Closed

[dynamo] Skip some tests using scipy.kstest#116263
peterbell10 wants to merge 3 commits intogh/peterbell10/676/basefrom
gh/peterbell10/676/head

Conversation

@peterbell10
Copy link
Copy Markdown
Collaborator

@peterbell10 peterbell10 commented Dec 21, 2023

Stack from ghstack (oldest at bottom):

These tests are failing in CI with this error

  File "/opt/conda/envs/py_3.11/lib/python3.11/site-packages/torch/_dynamo/variables/builder.py", line 1126, in wrap_numpy_ndarray
    value.flags.writeable = True
    ^^^^^^^^^^^^^^^^^^^^^
torch._dynamo.exc.InternalTorchDynamoError: cannot set WRITEABLE flag to True of this array

And it may be related to a SIGKILL exception being raised shortly after the
failure.

These tests are failing in CI with this error
```
  File "/opt/conda/envs/py_3.11/lib/python3.11/site-packages/torch/_dynamo/variables/builder.py", line 1126, in wrap_numpy_ndarray
    value.flags.writeable = True
    ^^^^^^^^^^^^^^^^^^^^^
torch._dynamo.exc.InternalTorchDynamoError: cannot set WRITEABLE flag to True of this array
```

And it may be related to a `SIGKILL` exception being raised shortly after the
failure.

[ghstack-poisoned]
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Dec 21, 2023
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Dec 21, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/116263

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 61cde45 with merge base f2c1fb3 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

These tests are failing in CI with this error
```
  File "/opt/conda/envs/py_3.11/lib/python3.11/site-packages/torch/_dynamo/variables/builder.py", line 1126, in wrap_numpy_ndarray
    value.flags.writeable = True
    ^^^^^^^^^^^^^^^^^^^^^
torch._dynamo.exc.InternalTorchDynamoError: cannot set WRITEABLE flag to True of this array
```

And it may be related to a `SIGKILL` exception being raised shortly after the
failure.

[ghstack-poisoned]
These tests are failing in CI with this error
```
  File "/opt/conda/envs/py_3.11/lib/python3.11/site-packages/torch/_dynamo/variables/builder.py", line 1126, in wrap_numpy_ndarray
    value.flags.writeable = True
    ^^^^^^^^^^^^^^^^^^^^^
torch._dynamo.exc.InternalTorchDynamoError: cannot set WRITEABLE flag to True of this array
```

And it may be related to a `SIGKILL` exception being raised shortly after the
failure.

[ghstack-poisoned]
Copy link
Copy Markdown
Collaborator

@lezcano lezcano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do they also fail locally? If so, can you fill in an issue? The fix shouldn't be too difficult.

peterbell10 added a commit to peterbell10/pytorch that referenced this pull request Dec 21, 2023
These tests are failing in CI with this error
```
  File "/opt/conda/envs/py_3.11/lib/python3.11/site-packages/torch/_dynamo/variables/builder.py", line 1126, in wrap_numpy_ndarray
    value.flags.writeable = True
    ^^^^^^^^^^^^^^^^^^^^^
torch._dynamo.exc.InternalTorchDynamoError: cannot set WRITEABLE flag to True of this array
```

And it may be related to a `SIGKILL` exception being raised shortly after the
failure.

ghstack-source-id: 214f351
Pull Request resolved: pytorch#116263
@peterbell10 peterbell10 marked this pull request as ready for review December 21, 2023 16:55
@peterbell10
Copy link
Copy Markdown
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 21, 2023
@pytorchmergebot
Copy link
Copy Markdown
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

Merge failed

Reason: Not merging any PRs at the moment because there is a merge blocking https://github.com/pytorch/pytorch/labels/ci:%20sev issue open at:
#116273

Details for Dev Infra team Raised by workflow job

@kit1980
Copy link
Copy Markdown
Contributor

kit1980 commented Dec 21, 2023

@peterbell10 force-merge this if it fixes CI.

@peterbell10
Copy link
Copy Markdown
Collaborator Author

@pytorchbot merge -f

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Dec 21, 2023

❌ 🤖 pytorchbot command failed:

@pytorchbot merge: error: argument -f/--force: expected one argument

usage: @pytorchbot merge [-f MESSAGE | -i] [-ic] [-r [{viable/strict,main}]]

Try @pytorchbot --help for more info.

@peterbell10
Copy link
Copy Markdown
Collaborator Author

@pytorchbot merge -f "Fixes CI failure that is blocking merges"

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@peterbell10
Copy link
Copy Markdown
Collaborator Author

This should fix one of the failures, I see there's now a lot more than when I last looked though.

@facebook-github-bot facebook-github-bot deleted the gh/peterbell10/676/head branch December 25, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants