[dynamo] Test for using torch.nn when replay_records are enabled#116215
Closed
peterbell10 wants to merge 15 commits intogh/peterbell10/674/basefrom
Closed
[dynamo] Test for using torch.nn when replay_records are enabled#116215peterbell10 wants to merge 15 commits intogh/peterbell10/674/basefrom
peterbell10 wants to merge 15 commits intogh/peterbell10/674/basefrom
Conversation
The top level `torch` module is ignored, and so anything underneath it will fail
when accessed with the error:
```python
File ~/git/pytorch/torch/_dynamo/replay_record.py:80, in ExecutionRecorder.record_module_access(self, mod, name, val)
78 return
79 if isinstance(val, ModuleType):
---> 80 self.name_to_modrec[mod.__name__].accessed_attrs[name] = self._add_mod(val)
81 return
83 if mod.__name__ in self.name_to_modrec:
InternalTorchDynamoError: torch.nn
```
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/116215
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 8a2d7b3 with merge base 5ec2d79 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
The top level `torch` module is ignored, and so anything underneath it will fail
when accessed with the error:
```python
File ~/git/pytorch/torch/_dynamo/replay_record.py:80, in ExecutionRecorder.record_module_access(self, mod, name, val)
78 return
79 if isinstance(val, ModuleType):
---> 80 self.name_to_modrec[mod.__name__].accessed_attrs[name] = self._add_mod(val)
81 return
83 if mod.__name__ in self.name_to_modrec:
InternalTorchDynamoError: torch.nn
```
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng
[ghstack-poisoned]
peterbell10
added a commit
that referenced
this pull request
Dec 21, 2023
The top level `torch` module is ignored, and so anything underneath it will fail
when accessed with the error:
```python
File ~/git/pytorch/torch/_dynamo/replay_record.py:80, in ExecutionRecorder.record_module_access(self, mod, name, val)
78 return
79 if isinstance(val, ModuleType):
---> 80 self.name_to_modrec[mod.__name__].accessed_attrs[name] = self._add_mod(val)
81 return
83 if mod.__name__ in self.name_to_modrec:
InternalTorchDynamoError: torch.nn
```
ghstack-source-id: de04e95
Pull Request resolved: #116215
lezcano
reviewed
Dec 21, 2023
The top level `torch` module is ignored, and so anything underneath it will fail
when accessed with the error:
```python
File ~/git/pytorch/torch/_dynamo/replay_record.py:80, in ExecutionRecorder.record_module_access(self, mod, name, val)
78 return
79 if isinstance(val, ModuleType):
---> 80 self.name_to_modrec[mod.__name__].accessed_attrs[name] = self._add_mod(val)
81 return
83 if mod.__name__ in self.name_to_modrec:
InternalTorchDynamoError: torch.nn
```
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng
[ghstack-poisoned]
The top level `torch` module is ignored, and so anything underneath it will fail
when accessed with the error:
```python
File ~/git/pytorch/torch/_dynamo/replay_record.py:80, in ExecutionRecorder.record_module_access(self, mod, name, val)
78 return
79 if isinstance(val, ModuleType):
---> 80 self.name_to_modrec[mod.__name__].accessed_attrs[name] = self._add_mod(val)
81 return
83 if mod.__name__ in self.name_to_modrec:
InternalTorchDynamoError: torch.nn
```
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng
[ghstack-poisoned]
The top level `torch` module is ignored, and so anything underneath it will fail
when accessed with the error:
```python
File ~/git/pytorch/torch/_dynamo/replay_record.py:80, in ExecutionRecorder.record_module_access(self, mod, name, val)
78 return
79 if isinstance(val, ModuleType):
---> 80 self.name_to_modrec[mod.__name__].accessed_attrs[name] = self._add_mod(val)
81 return
83 if mod.__name__ in self.name_to_modrec:
InternalTorchDynamoError: torch.nn
```
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng
[ghstack-poisoned]
The top level `torch` module is ignored, and so anything underneath it will fail
when accessed with the error:
```python
File ~/git/pytorch/torch/_dynamo/replay_record.py:80, in ExecutionRecorder.record_module_access(self, mod, name, val)
78 return
79 if isinstance(val, ModuleType):
---> 80 self.name_to_modrec[mod.__name__].accessed_attrs[name] = self._add_mod(val)
81 return
83 if mod.__name__ in self.name_to_modrec:
InternalTorchDynamoError: torch.nn
```
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng
[ghstack-poisoned]
The top level `torch` module is ignored, and so anything underneath it will fail
when accessed with the error:
```python
File ~/git/pytorch/torch/_dynamo/replay_record.py:80, in ExecutionRecorder.record_module_access(self, mod, name, val)
78 return
79 if isinstance(val, ModuleType):
---> 80 self.name_to_modrec[mod.__name__].accessed_attrs[name] = self._add_mod(val)
81 return
83 if mod.__name__ in self.name_to_modrec:
InternalTorchDynamoError: torch.nn
```
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng
[ghstack-poisoned]
The top level `torch` module is ignored, and so anything underneath it will fail
when accessed with the error:
```python
File ~/git/pytorch/torch/_dynamo/replay_record.py:80, in ExecutionRecorder.record_module_access(self, mod, name, val)
78 return
79 if isinstance(val, ModuleType):
---> 80 self.name_to_modrec[mod.__name__].accessed_attrs[name] = self._add_mod(val)
81 return
83 if mod.__name__ in self.name_to_modrec:
InternalTorchDynamoError: torch.nn
```
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng
[ghstack-poisoned]
peterbell10
added a commit
that referenced
this pull request
Dec 21, 2023
The top level `torch` module is ignored, and so anything underneath it will fail
when accessed with the error:
```python
File ~/git/pytorch/torch/_dynamo/replay_record.py:80, in ExecutionRecorder.record_module_access(self, mod, name, val)
78 return
79 if isinstance(val, ModuleType):
---> 80 self.name_to_modrec[mod.__name__].accessed_attrs[name] = self._add_mod(val)
81 return
83 if mod.__name__ in self.name_to_modrec:
InternalTorchDynamoError: torch.nn
```
ghstack-source-id: 753e40b
Pull Request resolved: #116215
The top level `torch` module is ignored, and so anything underneath it will fail
when accessed with the error:
```python
File ~/git/pytorch/torch/_dynamo/replay_record.py:80, in ExecutionRecorder.record_module_access(self, mod, name, val)
78 return
79 if isinstance(val, ModuleType):
---> 80 self.name_to_modrec[mod.__name__].accessed_attrs[name] = self._add_mod(val)
81 return
83 if mod.__name__ in self.name_to_modrec:
InternalTorchDynamoError: torch.nn
```
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng
[ghstack-poisoned]
peterbell10
added a commit
that referenced
this pull request
Dec 22, 2023
The top level `torch` module is ignored, and so anything underneath it will fail
when accessed with the error:
```python
File ~/git/pytorch/torch/_dynamo/replay_record.py:80, in ExecutionRecorder.record_module_access(self, mod, name, val)
78 return
79 if isinstance(val, ModuleType):
---> 80 self.name_to_modrec[mod.__name__].accessed_attrs[name] = self._add_mod(val)
81 return
83 if mod.__name__ in self.name_to_modrec:
InternalTorchDynamoError: torch.nn
```
ghstack-source-id: b4859fe
Pull Request resolved: #116215
…ing torch.nn when replay_records are enabled"
The top level `torch` module is ignored, and so anything underneath it will fail
when accessed with the error:
```python
File ~/git/pytorch/torch/_dynamo/replay_record.py:80, in ExecutionRecorder.record_module_access(self, mod, name, val)
78 return
79 if isinstance(val, ModuleType):
---> 80 self.name_to_modrec[mod.__name__].accessed_attrs[name] = self._add_mod(val)
81 return
83 if mod.__name__ in self.name_to_modrec:
InternalTorchDynamoError: torch.nn
```
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng
[ghstack-poisoned]
peterbell10
added a commit
that referenced
this pull request
Dec 22, 2023
The top level `torch` module is ignored, and so anything underneath it will fail
when accessed with the error:
```python
File ~/git/pytorch/torch/_dynamo/replay_record.py:80, in ExecutionRecorder.record_module_access(self, mod, name, val)
78 return
79 if isinstance(val, ModuleType):
---> 80 self.name_to_modrec[mod.__name__].accessed_attrs[name] = self._add_mod(val)
81 return
83 if mod.__name__ in self.name_to_modrec:
InternalTorchDynamoError: torch.nn
```
ghstack-source-id: 6e4e316
Pull Request resolved: #116215
jansel
approved these changes
Dec 23, 2023
The top level `torch` module is ignored, and so anything underneath it will fail
when accessed with the error:
```python
File ~/git/pytorch/torch/_dynamo/replay_record.py:80, in ExecutionRecorder.record_module_access(self, mod, name, val)
78 return
79 if isinstance(val, ModuleType):
---> 80 self.name_to_modrec[mod.__name__].accessed_attrs[name] = self._add_mod(val)
81 return
83 if mod.__name__ in self.name_to_modrec:
InternalTorchDynamoError: torch.nn
```
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng
[ghstack-poisoned]
The top level `torch` module is ignored, and so anything underneath it will fail
when accessed with the error:
```python
File ~/git/pytorch/torch/_dynamo/replay_record.py:80, in ExecutionRecorder.record_module_access(self, mod, name, val)
78 return
79 if isinstance(val, ModuleType):
---> 80 self.name_to_modrec[mod.__name__].accessed_attrs[name] = self._add_mod(val)
81 return
83 if mod.__name__ in self.name_to_modrec:
InternalTorchDynamoError: torch.nn
```
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng
[ghstack-poisoned]
…ds are enabled"
The top level `torch` module is ignored, and so anything underneath it will fail
when accessed with the error:
```python
File ~/git/pytorch/torch/_dynamo/replay_record.py:80, in ExecutionRecorder.record_module_access(self, mod, name, val)
78 return
79 if isinstance(val, ModuleType):
---> 80 self.name_to_modrec[mod.__name__].accessed_attrs[name] = self._add_mod(val)
81 return
83 if mod.__name__ in self.name_to_modrec:
InternalTorchDynamoError: torch.nn
```
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng
[ghstack-poisoned]
peterbell10
added a commit
to peterbell10/pytorch
that referenced
this pull request
Jan 24, 2024
The top level `torch` module is ignored, and so anything underneath it will fail
when accessed with the error:
```python
File ~/git/pytorch/torch/_dynamo/replay_record.py:80, in ExecutionRecorder.record_module_access(self, mod, name, val)
78 return
79 if isinstance(val, ModuleType):
---> 80 self.name_to_modrec[mod.__name__].accessed_attrs[name] = self._add_mod(val)
81 return
83 if mod.__name__ in self.name_to_modrec:
InternalTorchDynamoError: torch.nn
```
ghstack-source-id: 3b4ae11
Pull Request resolved: pytorch#116215
…nabled" This adds a reproducer for a failure that has since been fixed in main. [ghstack-poisoned]
…nabled" This adds a reproducer for a failure that has since been fixed in main. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng [ghstack-poisoned]
Collaborator
Author
|
@pytorchmergebot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This adds a reproducer for a failure that has since been fixed in main.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @aakhundov @kadeng