[CI] Install dill in ci#116214
Closed
peterbell10 wants to merge 15 commits intogh/peterbell10/673/basefrom
Closed
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/116214
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 6e2cf50 with merge base 5ec2d79 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng [ghstack-poisoned]
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng [ghstack-poisoned]
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng [ghstack-poisoned]
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng [ghstack-poisoned]
…ll in ci" cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng [ghstack-poisoned]
peterbell10
commented
Dec 22, 2023
| def test_multiprocessing_iterdatapipe(self): | ||
| self._test_multiprocessing_iterdatapipe(with_dill=False) | ||
|
|
||
| @unittest.expectedFailure |
Collaborator
Author
There was a problem hiding this comment.
This test fails in CI when the HAS_DILL code is active, so keeping the non-dill version active and xfailing the version with dill for now.
Collaborator
|
ping @malfet |
malfet
approved these changes
Jan 23, 2024
Contributor
malfet
left a comment
There was a problem hiding this comment.
Looks good to me, but it feels like this PR solves the problem when tests are running with dill, but does not test that PyTorch will not accidentally introduce unconditional dependency on dill, because its present in all CI configs.
Can we somehow keep one of the Linux CPU configs without dill(i.e. modify one of the test configs not uninstall dill before running the tests)
.ci/docker/requirements-ci.txt
Outdated
| #Pinned versions: | ||
| #test that import: | ||
|
|
||
| dill |
Contributor
There was a problem hiding this comment.
Please specify the version that you want to use.
We have CI tests that depend on `dill` but none of the CI runners have it installed. This installs `dill` and fixes a bunch of broken tests and refactoring how dill is imported to avoid changing the default pickle behavior. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng [ghstack-poisoned]
We have CI tests that depend on `dill` but none of the CI runners have it installed. This installs `dill` and fixes a bunch of broken tests and refactoring how dill is imported to avoid changing the default pickle behavior. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng [ghstack-poisoned]
We have CI tests that depend on `dill` but none of the CI runners have it installed. This installs `dill` and fixes a bunch of broken tests and refactoring how dill is imported to avoid changing the default pickle behavior. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng [ghstack-poisoned]
peterbell10
added a commit
to peterbell10/pytorch
that referenced
this pull request
Jan 24, 2024
ghstack-source-id: 3c853c4 Pull Request resolved: pytorch#116214
[ghstack-poisoned]
[ghstack-poisoned]
pytorchmergebot
pushed a commit
that referenced
this pull request
Jan 24, 2024
…6215) This adds a reproducer for a failure that has since been fixed in main. Pull Request resolved: #116215 Approved by: https://github.com/jansel ghstack dependencies: #116230, #116214
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @aakhundov @kadeng