Conversation
|
What exactly will the even with uuid-dev installed. |
|
@ssnl I'll make sure the environment flag can be set and that it applies to all of those. |
be65c40 to
3291cf2
Compare
facebook-github-bot
left a comment
There was a problem hiding this comment.
orionr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
soumith
left a comment
There was a problem hiding this comment.
lgtm. what is "Build C++ binaries", what are the C++ binaries that we build apart from tests?
|
@soumith - good question. These are things like DB conversion, benchmarking, data loaders, etc. |
152d36a to
486067d
Compare
facebook-github-bot
left a comment
There was a problem hiding this comment.
orionr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@soumith the binaries are the native C++ binaries that C2 had, such as speed_benchmark etc. Might not be much useful in the python releases so we can probably turn it off by default. |
|
Another downside of the binaries is that they are installed in |
8e99de5 to
b4d73a1
Compare
facebook-github-bot
left a comment
There was a problem hiding this comment.
orionr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
non-blocking: #11388 fixes googletest issue. |
facebook-github-bot
left a comment
There was a problem hiding this comment.
orionr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
The pytorch-linux-xenial-cuda9 error looks like it's the same as one on master. Going to ignore that. |
Summary: Continuing pjh5's work to remove FULL_CAFFE2 flag completely. With these changes you'll be able to also do something like ``` NO_TEST=1 python setup.py build_deps ``` and this will skip building tests in caffe2, aten, and c10d. By default the tests are built. cc mingzhe09088 Yangqing Pull Request resolved: pytorch/pytorch#11321 Reviewed By: mingzhe09088 Differential Revision: D9694950 Pulled By: orionr fbshipit-source-id: ff5c4937a23d1a263378a196a5eda0cba98af0a8
|
Can confirm that this fixes the build on devfair (with NO_TEST=1)! Thanks! |
Summary: Continuing pjh5's work to remove FULL_CAFFE2 flag completely. With these changes you'll be able to also do something like ``` NO_TEST=1 python setup.py build_deps ``` and this will skip building tests in caffe2, aten, and c10d. By default the tests are built. cc mingzhe09088 Yangqing Pull Request resolved: pytorch#11321 Reviewed By: mingzhe09088 Differential Revision: D9694950 Pulled By: orionr fbshipit-source-id: ff5c4937a23d1a263378a196a5eda0cba98af0a8
Continuing @pjh5's work to remove FULL_CAFFE2 flag completely.
With these changes you'll be able to also do something like
and this will skip building tests in caffe2, aten, and c10d. By default the tests are built.
Also, BUILD_BINARIES and USE_OPENCV are OFF by default and BUILD_TEST is ON by default.
cc @mingzhe09088 @Yangqing