[build] Update gtest and remove the macro guide on gtest from #11321#11417
Closed
Yangqing wants to merge 2 commits intopytorch:masterfrom
Closed
[build] Update gtest and remove the macro guide on gtest from #11321#11417Yangqing wants to merge 2 commits intopytorch:masterfrom
Yangqing wants to merge 2 commits intopytorch:masterfrom
Conversation
Contributor
Author
|
Turns out 1.8.1 is having a bunch of errors and 1.8.0 is 2 years ago, so we'll just keep the cmake hack. |
Contributor
Author
|
(reopening because 1.8.1 seems to be needed for parallel build for Windows) |
Contributor
Author
|
Note: pr/caffe2-py2-cuda9.1-cudnn7-ubuntu16.04-test is manually rerun in https://ci.pytorch.org/jenkins/job/caffe2-builds/job/py2-cuda9.1-cudnn7-ubuntu16.04-test/10234/ and passes. rocm is known to fail. |
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
orionr is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Sep 12, 2018
Summary: Last PR seems to have test failures, re-issuing. Pull Request resolved: pytorch/pytorch#11417 Reviewed By: orionr Differential Revision: D9784706 Pulled By: Yangqing fbshipit-source-id: 9e5f347e19fa2700ff69d2cd69ea7a9e01a91609
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last PR seems to have test failures, re-issuing.