[third-party] Update googletest to release-1.8.1#11388
Closed
Yangqing wants to merge 1 commit intopytorch:masterfrom
Closed
[third-party] Update googletest to release-1.8.1#11388Yangqing wants to merge 1 commit intopytorch:masterfrom
Yangqing wants to merge 1 commit intopytorch:masterfrom
Conversation
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
Yangqing has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
orionr
approved these changes
Sep 7, 2018
PenghuiCheng
pushed a commit
to PenghuiCheng/pytorch
that referenced
this pull request
Sep 11, 2018
Summary: This is mainly to pick up the change google/googletest@20074be to avoid polluting the CMAKE_DEBUG_POSTFIX variable. cc orionr . Pull Request resolved: pytorch#11388 Reviewed By: orionr Differential Revision: D9720931 Pulled By: Yangqing fbshipit-source-id: 18a60d0409e74316f74d364f4fe16bf0d0198413
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is mainly to pick up the change google/googletest@20074be to avoid polluting the CMAKE_DEBUG_POSTFIX variable. cc @orionr .