Closed
Conversation
Differential Revision: D9652088 Differential Version: 56917655
Differential Revision: D9652088 Differential Version: 56918713
ezyang
approved these changes
Sep 5, 2018
Contributor
ezyang
left a comment
There was a problem hiding this comment.
I always have to check my Meyers to remember when I'm allowed to combine them this way...
Differential Revision: D9652088 Differential Version: 56982465
Differential Revision: D9652088 Differential Version: 57101545
Differential Revision: D9652088 Differential Version: 57135218
Differential Revision: D9652088 Differential Version: 57214005
This was referenced Sep 7, 2018
Closed
Closed
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Sep 10, 2018
Summary: Pull Request resolved: pytorch/pytorch#11258 The two intrusive_ptr constructors in Tensor can be combined into one implementation that does both, moving and copying. Reviewed By: ezyang Differential Revision: D9652088 fbshipit-source-id: 5efca02654ba305c99c20bbeb83551469d17a51d
PenghuiCheng
pushed a commit
to PenghuiCheng/pytorch
that referenced
this pull request
Sep 11, 2018
Summary: Pull Request resolved: pytorch#11258 The two intrusive_ptr constructors in Tensor can be combined into one implementation that does both, moving and copying. Reviewed By: ezyang Differential Revision: D9652088 fbshipit-source-id: 5efca02654ba305c99c20bbeb83551469d17a51d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack:
:white_circle: #11167 Narrowing Blob 💛
:white_circle: #11238 Some improvements to IValue 💛
:black_circle: #11258 Improve Tensor() constructor 💛
:white_circle: #11260 Fix intrusive_ptr move/copy for different NullType's 💛
:white_circle: #11294 Remove manual refcounting from Tensor class 💛
:white_circle: #11352 Remove intrusive_ptr::reclaim() in Storage 💛
:white_circle: #11353 Simplify union payload copying 💛
:white_circle: #11355 Simplify IValue::toTensor() 💛
:white_circle: #11402 Simplify Blob move constructor/assignment 💛
:white_circle: #11414 IValue can store Blob 💛
:white_circle: #11481 Blob doesn't allow access to destroyCall anymore 💛
The two intrusive_ptr constructors in Tensor can be combined into one implementation that does both, moving and copying.
Differential Revision: D9652088