Closed
Conversation
Differential Revision: D9623916 Differential Version: 56705898
ezyang
approved these changes
Sep 2, 2018
Contributor
ezyang
left a comment
There was a problem hiding this comment.
Don't forget to say in your commit message what you actually narrowed. (In this case, you got rid of templated IsType and changed the deleter type... be more specific!)
ezyang
reviewed
Sep 2, 2018
| TypeMeta meta_; | ||
| void* pointer_ = nullptr; | ||
| DestroyCall destroy_ = nullptr; | ||
| DestroyCall* destroy_ = nullptr; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Contributor
|
Also, if a codemod was used, put it in the commit description too. |
Contributor
Author
|
I expanded the description. Didn't use a codemod but changed the call sites manually. |
Differential Revision: D9623916 Differential Version: 56858422
Differential Revision: D9623916 Differential Version: 56900314
Differential Revision: D9623916 Differential Version: 56982469
Differential Revision: D9623916 Differential Version: 57101548
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
smessmer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Differential Revision: D9623916 Differential Version: 57135223
Differential Revision: D9623916 Differential Version: 57214033
This was referenced Sep 7, 2018
Closed
PenghuiCheng
pushed a commit
to PenghuiCheng/pytorch
that referenced
this pull request
Sep 11, 2018
Summary: Pull Request resolved: pytorch#11167 Narrow the Blob API as preparation for merging Blob/IValue - get rid of templated IsType and Operator::InputIsType / OutputIsType - Use 'using' instead of 'typedef' for DestroyCall (just for readability) Reviewed By: ezyang Differential Revision: D9623916 fbshipit-source-id: 952f0b0cf5a525094b02e8d2798dd57a56a9e1d8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack:
:black_circle: #11167 Narrowing Blob 💛
:white_circle: #11238 Some improvements to IValue 💛
:white_circle: #11258 Improve Tensor() constructor 💛
:white_circle: #11260 Fix intrusive_ptr move/copy for different NullType's 💛
:white_circle: #11294 Remove manual refcounting from Tensor class 💛
:white_circle: #11352 Remove intrusive_ptr::reclaim() in Storage 💛
:white_circle: #11353 Simplify union payload copying 💛
:white_circle: #11355 Simplify IValue::toTensor() 💛
:white_circle: #11402 Simplify Blob move constructor/assignment 💛
:white_circle: #11414 IValue can store Blob 💛
:white_circle: #11481 Blob doesn't allow access to destroyCall anymore 💛
Narrow the Blob API as preparation for merging Blob/IValue
Differential Revision: D9623916