Skip to content

Remove intrusive_ptr::reclaim() in Storage#11352

Closed
smessmer wants to merge 43 commits intomasterfrom
export-D9694327
Closed

Remove intrusive_ptr::reclaim() in Storage#11352
smessmer wants to merge 43 commits intomasterfrom
export-D9694327

Conversation

@smessmer
Copy link
Contributor

@smessmer smessmer commented Sep 6, 2018 •
edited
Loading

Stack:
    :black_circle:  #11352 Remove intrusive_ptr::reclaim() in Storage  💛
    :white_circle:  #11547 Remove intrusive_ptr::reclaim() in Storage (2/2)  💚
    :white_circle:  #11353 Simplify union payload copying  💛
    :white_circle:  #11355 Simplify IValue::toTensor()  💛
    :white_circle:  #11402 Simplify Blob move constructor/assignment  💛
    :white_circle:  #11414 IValue can store Blob  💛
    :white_circle:  #11548 Blob doesn't allow access to destroyCall anymore  💛
    :white_circle:  #11500 Use TypeMeta::dtor() instead of Blob::DestroyCall  💛
    :white_circle:  #11501 Move GetExceptionString to Error.h  💛
    :white_circle:  #11502 Improve TypeMeta  💛

Pushing manual refcounting further back, making things safer.

Differential Revision: D9694327

smessmer added 24 commits August 31, 2018 17:28
@smessmer
V1: Initial commit
9aa3376 
Differential Revision: D9623916
Differential Version: 56705898
@smessmer
V1: (no description)
4009f39 
Differential Revision: D9623916
Differential Version: 56858422
@smessmer
V1: Initial commit
dc77c53 
Differential Revision: D9644700
Differential Version: 56870160
@smessmer
V3: Merge with parent diff changes
fb12714 
Differential Revision: D9623916
Differential Version: 56900314
@smessmer
V2: Merge with parent diff changes
f2269a8 
Differential Revision: D9644700
Differential Version: 56900331
@smessmer
V1: Initial commit
3989ddf 
Differential Revision: D9652088
Differential Version: 56917655
@smessmer
V2: (no description)
c24727a 
Differential Revision: D9652088
Differential Version: 56918713
@smessmer
V2: Initial commit
f2c2533 
Differential Revision: D9652089
Differential Version: 56918714
@smessmer
V5: Merge with parent diff changes
c2f28e6 
Differential Revision: D9623916
Differential Version: 56982469
@smessmer
V3: Merge with parent diff changes
f837a36 
Differential Revision: D9644700
Differential Version: 56982494
@smessmer
V3: Merge with parent diff changes
0903fd1 
Differential Revision: D9652088
Differential Version: 56982465
@smessmer
V3: Merge with parent diff changes
427978d 
Differential Revision: D9652089
Differential Version: 56982470
@smessmer
V2: Initial commit
b6ce141 
Differential Revision: D9663476
Differential Version: 56982467
@smessmer
V6: Merge with parent diff changes
f49854d 
Differential Revision: D9623916
Differential Version: 57101548
@smessmer
V4: Merge with parent diff changes
280c828 
Differential Revision: D9644700
Differential Version: 57101652
@smessmer
V4: Merge with parent diff changes
e97e187 
Differential Revision: D9652088
Differential Version: 57101545
@smessmer
V4: Merge with parent diff changes
269d4f0 
Differential Revision: D9652089
Differential Version: 57101550
@smessmer
V3: Merge with parent diff changes
1574284 
Differential Revision: D9663476
Differential Version: 57101556
@smessmer
V7: Merge with parent diff changes
5d2724b 
Differential Revision: D9623916
Differential Version: 57135223
@smessmer
V5: Merge with parent diff changes
039695e 
Differential Revision: D9644700
Differential Version: 57135224
@smessmer
V5: Merge with parent diff changes
e162a1c 
Differential Revision: D9652088
Differential Version: 57135218
@smessmer
V6: Merge with parent diff changes
81e98e0 
Differential Revision: D9652089
Differential Version: 57135219
@smessmer
V4: Merge with parent diff changes
d2e0838 
Differential Revision: D9663476
Differential Version: 57135226
@smessmer
V1: Initial commit
4c1d3e7 
Differential Revision: D9694327
Differential Version: 57135227
This was referenced Sep 11, 2018
Closed
Closed
Closed
@smessmer
V2: Initial commit
5a5c68e 
Differential Revision: D9778043
Differential Version: 57535396
@smessmer
V7: Merge with parent diff changes
06cb9a9 
Differential Revision: D9694327
Differential Version: 57535399
@smessmer smessmer mentioned this pull request Sep 11, 2018
Closed
@smessmer smessmer changed the base branch from master to export-D9778043 September 11, 2018 20:57
This was referenced Sep 11, 2018
Closed
Closed
@smessmer
V3: (no description)
77a9ee2 
Differential Revision: D9778043
Differential Version: 57551489
@smessmer
V8: Merge with parent diff changes
50bdce7 
Differential Revision: D9694327
Differential Version: 57551491
@smessmer
Copy link
Contributor Author

smessmer commented Sep 12, 2018

@ezyang ASAN failure was in a diff stacked below and should be fixed now

@goldsborough
Copy link
Contributor

goldsborough commented Sep 12, 2018

Why are all codeowners being subscribed? :(

@smessmer
V4: (no description)
d23a9b9 
Differential Revision: D9778043
Differential Version: 57670065
@smessmer
V9: Merge with parent diff changes
f05b630 
Differential Revision: D9694327
Differential Version: 57670063
@smessmer
Copy link
Contributor Author

smessmer commented Sep 13, 2018

@goldsborough no idea, is that something your tool did @ezyang ?

@ezyang
Copy link
Contributor

ezyang commented Sep 13, 2018

Maybe GitHub gets confused about the merge commits...

@ezyang
Copy link
Contributor

ezyang commented Sep 13, 2018

Your build is still failing.

00:24:08 + python -c 'import torch'
00:24:09 /var/lib/jenkins/workspace/aten/src/ATen/core/Storage.h:37:27: runtime error: member call on null pointer of type 'at::StorageImpl'
00:24:09     #0 0x7fdd78d351c0 in at::Storage::dtype() const (/opt/conda/lib/python3.6/site-packages/torch/lib/libcaffe2.so+0x51f41c0)
00:24:09     #1 0x7fdd78d330fe in at::TensorImpl::TensorImpl(at::Storage, at::TensorTypeId, bool) (/opt/conda/lib/python3.6/site-packages/torch/lib/libcaffe2.so+0x51f20fe)
00:24:09     #2 0x7fdd78d32a69 in at::TensorImpl::TensorImpl(at::TensorTypeId, at::ScalarType, at::Allocator*, bool) (/opt/conda/lib/python3.6/site-packages/torch/lib/libcaffe2.so+0x51f1a69)
00:24:09     #3 0x7fdd78b61682 in _GLOBAL__sub_I_UndefinedTensorImpl.cpp (/opt/conda/lib/python3.6/site-packages/torch/lib/libcaffe2.so+0x5020682)
00:24:09     #4 0x7fdd9b3b16b9 in call_init /build/glibc-Cl5G7W/glibc-2.23/elf/dl-init.c:72
00:24:09     #5 0x7fdd9b3b17ca in call_init /build/glibc-Cl5G7W/glibc-2.23/elf/dl-init.c:30
00:24:09     #6 0x7fdd9b3b17ca in _dl_init /build/glibc-Cl5G7W/glibc-2.23/elf/dl-init.c:120
00:24:09     #7 0x7fdd9b3b68e1 in dl_open_worker /build/glibc-Cl5G7W/glibc-2.23/elf/dl-open.c:575
00:24:09     #8 0x7fdd9b3b1563 in _dl_catch_error /build/glibc-Cl5G7W/glibc-2.23/elf/dl-error.c:187
00:24:09     #9 0x7fdd9b3b5da8 in _dl_open /build/glibc-Cl5G7W/glibc-2.23/elf/dl-open.c:660
00:24:09     #10 0x7fdd99d7cf08 in __asprintf /build/glibc-Cl5G7W/glibc-2.23/dlfcn/dlopen.c:66
00:24:09     #11 0x7fdd9b3b1563 in _dl_catch_error /build/glibc-Cl5G7W/glibc-2.23/elf/dl-error.c:187
00:24:09     #12 0x7fdd99d7d570 in _dlerror_run /build/glibc-Cl5G7W/glibc-2.23/dlfcn/dlerror.c:163
00:24:09     #13 0x7fdd99d7cfa0 in dlopen /build/glibc-Cl5G7W/glibc-2.23/dlfcn/dlopen.c:87
00:24:09     #14 0x7fdd9a61ef3f in dlopen (/usr/lib/llvm-5.0/lib/clang/5.0.0/lib/linux/libclang_rt.asan-x86_64.so+0xb7f3f)
00:24:09     #15 0x5568bccf6379 in _PyImport_FindSharedFuncptr (/opt/conda/bin/python3.6+0x1ef379)
00:24:09     #16 0x5568bcd1cb3f in _PyImport_LoadDynamicModuleWithSpec (/opt/conda/bin/python3.6+0x215b3f)
00:24:09     #17 0x5568bcd1cd84 in _imp_create_dynamic (/opt/conda/bin/python3.6+0x215d84)
00:24:09     #18 0x5568bcc19ae0 in PyCFunction_Call (/opt/conda/bin/python3.6+0x112ae0)
00:24:09     #19 0x5568bcccdaab in _PyEval_EvalFrameDefault (/opt/conda/bin/python3.6+0x1c6aab)
00:24:09     #20 0x5568bcc9d205 in _PyEval_EvalCodeWithName (/opt/conda/bin/python3.6+0x196205)
00:24:09     #21 0x5568bcc9e1ce in fast_function (/opt/conda/bin/python3.6+0x1971ce)
00:24:09     #22 0x5568bcca3ed4 in call_function (/opt/conda/bin/python3.6+0x19ced4)
00:24:09     #23 0x5568bccc8949 in _PyEval_EvalFrameDefault (/opt/conda/bin/python3.6+0x1c1949)
00:24:09     #24 0x5568bcc9df8a in fast_function (/opt/conda/bin/python3.6+0x196f8a)
00:24:09     #25 0x5568bcca3ed4 in call_function (/opt/conda/bin/python3.6+0x19ced4)
00:24:09     #26 0x5568bccc8949 in _PyEval_EvalFrameDefault (/opt/conda/bin/python3.6+0x1c1949)
00:24:09     #27 0x5568bcc9df8a in fast_function (/opt/conda/bin/python3.6+0x196f8a)
00:24:09     #28 0x5568bcca3ed4 in call_function (/opt/conda/bin/python3.6+0x19ced4)
00:24:09     #29 0x5568bccc8949 in _PyEval_EvalFrameDefault (/opt/conda/bin/python3.6+0x1c1949)
00:24:09     #30 0x5568bcc9df8a in fast_function (/opt/conda/bin/python3.6+0x196f8a)
00:24:09     #31 0x5568bcca3ed4 in call_function (/opt/conda/bin/python3.6+0x19ced4)
00:24:09     #32 0x5568bccc8949 in _PyEval_EvalFrameDefault (/opt/conda/bin/python3.6+0x1c1949)
00:24:09     #33 0x5568bcc9df8a in fast_function (/opt/conda/bin/python3.6+0x196f8a)
00:24:09     #34 0x5568bcca3ed4 in call_function (/opt/conda/bin/python3.6+0x19ced4)
00:24:09     #35 0x5568bccc8949 in _PyEval_EvalFrameDefault (/opt/conda/bin/python3.6+0x1c1949)
00:24:09     #36 0x5568bcc9e5da in _PyFunction_FastCallDict (/opt/conda/bin/python3.6+0x1975da)
00:24:09     #37 0x5568bcc16dae in _PyObject_FastCallDict (/opt/conda/bin/python3.6+0x10fdae)
00:24:09     #38 0x5568bcc5a0df in _PyObject_CallMethodIdObjArgs (/opt/conda/bin/python3.6+0x1530df)
00:24:09     #39 0x5568bcc0d6df in PyImport_ImportModuleLevelObject (/opt/conda/bin/python3.6+0x1066df)
00:24:09     #40 0x5568bcccb38d in _PyEval_EvalFrameDefault (/opt/conda/bin/python3.6+0x1c438d)
00:24:09     #41 0x5568bcc9ecb8 in PyEval_EvalCodeEx (/opt/conda/bin/python3.6+0x197cb8)
00:24:09     #42 0x5568bcc9fa4b in PyEval_EvalCode (/opt/conda/bin/python3.6+0x198a4b)
00:24:09     #43 0x5568bccc626c in builtin_exec (/opt/conda/bin/python3.6+0x1bf26c)
00:24:09     #44 0x5568bcc19ae0 in PyCFunction_Call (/opt/conda/bin/python3.6+0x112ae0)
00:24:09     #45 0x5568bcccdaab in _PyEval_EvalFrameDefault (/opt/conda/bin/python3.6+0x1c6aab)
00:24:09     #46 0x5568bcc9d205 in _PyEval_EvalCodeWithName (/opt/conda/bin/python3.6+0x196205)
00:24:09     #47 0x5568bcc9e1ce in fast_function (/opt/conda/bin/python3.6+0x1971ce)
00:24:09     #48 0x5568bcca3ed4 in call_function (/opt/conda/bin/python3.6+0x19ced4)
00:24:09     #49 0x5568bccc8949 in _PyEval_EvalFrameDefault (/opt/conda/bin/python3.6+0x1c1949)
00:24:09     #50 0x5568bcc9df8a in fast_function (/opt/conda/bin/python3.6+0x196f8a)
00:24:09     #51 0x5568bcca3ed4 in call_function (/opt/conda/bin/python3.6+0x19ced4)
00:24:09     #52 0x5568bccc8949 in _PyEval_EvalFrameDefault (/opt/conda/bin/python3.6+0x1c1949)
00:24:09     #53 0x5568bcc9df8a in fast_function (/opt/conda/bin/python3.6+0x196f8a)
00:24:09     #54 0x5568bcca3ed4 in call_function (/opt/conda/bin/python3.6+0x19ced4)
00:24:09     #55 0x5568bccc8949 in _PyEval_EvalFrameDefault (/opt/conda/bin/python3.6+0x1c1949)
00:24:09     #56 0x5568bcc9df8a in fast_function (/opt/conda/bin/python3.6+0x196f8a)
00:24:09     #57 0x5568bcca3ed4 in call_function (/opt/conda/bin/python3.6+0x19ced4)
00:24:09     #58 0x5568bccc8949 in _PyEval_EvalFrameDefault (/opt/conda/bin/python3.6+0x1c1949)
00:24:09     #59 0x5568bcc9e5da in _PyFunction_FastCallDict (/opt/conda/bin/python3.6+0x1975da)
00:24:09     #60 0x5568bcc16dae in _PyObject_FastCallDict (/opt/conda/bin/python3.6+0x10fdae)
00:24:09     #61 0x5568bcc5a0df in _PyObject_CallMethodIdObjArgs (/opt/conda/bin/python3.6+0x1530df)
00:24:09     #62 0x5568bcc0d6df in PyImport_ImportModuleLevelObject (/opt/conda/bin/python3.6+0x1066df)
00:24:09     #63 0x5568bcccb38d in _PyEval_EvalFrameDefault (/opt/conda/bin/python3.6+0x1c438d)
00:24:09     #64 0x5568bcc9ecb8 in PyEval_EvalCodeEx (/opt/conda/bin/python3.6+0x197cb8)
00:24:09     #65 0x5568bcc9fa4b in PyEval_EvalCode (/opt/conda/bin/python3.6+0x198a4b)
00:24:09     #66 0x5568bcd1bc43 in run_mod (/opt/conda/bin/python3.6+0x214c43)
00:24:09     #67 0x5568bcd1bcdc in PyRun_StringFlags (/opt/conda/bin/python3.6+0x214cdc)
00:24:09     #68 0x5568bcd1bd3e in PyRun_SimpleStringFlags (/opt/conda/bin/python3.6+0x214d3e)
00:24:09     #69 0x5568bcd1fb00 in Py_Main (/opt/conda/bin/python3.6+0x218b00)
00:24:09     #70 0x5568bcbe775d in main (/opt/conda/bin/python3.6+0xe075d)
00:24:09     #71 0x7fdd99fa082f in __libc_start_main /build/glibc-Cl5G7W/glibc-2.23/csu/../csu/libc-start.c:291
00:24:09     #72 0x5568bcccf47a in _start (/opt/conda/bin/python3.6+0x1c847a)
00:24:09 
00:24:09 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /var/lib/jenkins/workspace/aten/src/ATen/core/Storage.h:37:27 in

@smessmer
V5: Merge with parent diff changes
abb5389 
Differential Revision: D9778043
Differential Version: 57695967
@smessmer
V10: Merge with parent diff changes
e10bf91 
Differential Revision: D9694327
Differential Version: 57695973
@smessmer
V6: Merge with parent diff changes
732467f 
Differential Revision: D9778043
Differential Version: 57757843
@smessmer
V11: Merge with parent diff changes
0f7a08c 
Differential Revision: D9694327
Differential Version: 57757844
@smessmer
V14: Merge with parent diff changes
7a8789c 
Differential Revision: D9694327
Differential Version: 57851523
@smessmer smessmer changed the base branch from export-D9778043 to master September 14, 2018 20:25
zdevito pushed a commit to zdevito/ATen that referenced this pull request Sep 15, 2018
@smessmer @facebook-github-bot
Remove intrusive_ptr::reclaim() in Storage (#11352)
243606a 
Summary:
Pull Request resolved: pytorch/pytorch#11352

Pushing manual refcounting further back, making things safer.

Reviewed By: ezyang

Differential Revision: D9694327

fbshipit-source-id: befdbcac199225383a93520472ee7c6511a0e9cd
@soumith soumith deleted the export-D9694327 branch February 21, 2019 12:10
@ezyang ezyang added the merged label Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

@apaszke apaszke Awaiting requested review from apaszke

@colesbury colesbury Awaiting requested review from colesbury

@gchanan gchanan Awaiting requested review from gchanan

@soumith soumith Awaiting requested review from soumith

@zdevito zdevito Awaiting requested review from zdevito

@anderspapitto anderspapitto Awaiting requested review from anderspapitto

@bddppq bddppq Awaiting requested review from bddppq

@dzhulgakov dzhulgakov Awaiting requested review from dzhulgakov

@ebetica ebetica Awaiting requested review from ebetica

@fmassa fmassa Awaiting requested review from fmassa

@goldsborough goldsborough Awaiting requested review from goldsborough

@houseroad houseroad Awaiting requested review from houseroad

@jamesr66a jamesr66a Awaiting requested review from jamesr66a

@pietern pietern Awaiting requested review from pietern

@ssnl ssnl Awaiting requested review from ssnl

@teng-li teng-li Awaiting requested review from teng-li

@Yangqing Yangqing Awaiting requested review from Yangqing

@zou3519 zou3519 Awaiting requested review from zou3519

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@smessmer @ezyang @goldsborough