[ExecuTorch] Make ForcedUnroll usage in bf16 BlasKernel actually work for -Oz builds#5247
Closed
swolchok wants to merge 3 commits intogh/swolchok/56/basefrom
Closed
[ExecuTorch] Make ForcedUnroll usage in bf16 BlasKernel actually work for -Oz builds#5247swolchok wants to merge 3 commits intogh/swolchok/56/basefrom
swolchok wants to merge 3 commits intogh/swolchok/56/basefrom
Conversation
… for -Oz builds Clang is very resistant to inlining under -Oz. For ForcedUnroll to actually unroll, we need to force-inline the lambda. Differential Revision: [D62154247](https://our.internmc.facebook.com/intern/diff/D62154247/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5247
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 263653c with merge base 3171ede ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62154247 |
This was referenced Sep 10, 2024
kimishpatel
approved these changes
Sep 10, 2024
…tually work for -Oz builds" Clang is very resistant to inlining under -Oz. For ForcedUnroll to actually unroll, we need to force-inline the lambda. Differential Revision: [D62154247](https://our.internmc.facebook.com/intern/diff/D62154247/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62154247 |
…tually work for -Oz builds" Clang is very resistant to inlining under -Oz. For ForcedUnroll to actually unroll, we need to force-inline the lambda. Differential Revision: [D62154247](https://our.internmc.facebook.com/intern/diff/D62154247/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62154247 |
Contributor
|
This pull request has been merged in 88508c5. |
kedarnath03
pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
… for -Oz builds Pull Request resolved: pytorch/executorch#5247 Clang is very resistant to inlining under -Oz. For ForcedUnroll to actually unroll, we need to force-inline the lambda. ghstack-source-id: 242067820 @exported-using-ghexport Differential Revision: [D62154247](https://our.internmc.facebook.com/intern/diff/D62154247/)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Clang is very resistant to inlining under -Oz. For ForcedUnroll to actually unroll, we need to force-inline the lambda.
Differential Revision: D62154247