[ExecuTorch] Use parallel_for in bfloat16 gemm_transa_ kernel#5248
Closed
swolchok wants to merge 11 commits intogh/swolchok/57/basefrom
Closed
[ExecuTorch] Use parallel_for in bfloat16 gemm_transa_ kernel#5248swolchok wants to merge 11 commits intogh/swolchok/57/basefrom
swolchok wants to merge 11 commits intogh/swolchok/57/basefrom
Conversation
The upstream kernel uses this, I just didn't port it at first. Differential Revision: [D62154262](https://our.internmc.facebook.com/intern/diff/D62154262/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5248
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 97e0265 with merge base 1793c4a ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62154262 |
This was referenced Sep 10, 2024
kimishpatel
approved these changes
Sep 10, 2024
…nel" The upstream kernel uses this, I just didn't port it at first. Differential Revision: [D62154262](https://our.internmc.facebook.com/intern/diff/D62154262/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62154262 |
Contributor
Author
|
cmake builds are failing because cmake doesn't automatically pull transitive deps properly; they need pthreadpool :( |
…nel" The upstream kernel uses this, I just didn't port it at first. Differential Revision: [D62154262](https://our.internmc.facebook.com/intern/diff/D62154262/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62154262 |
swolchok
added a commit
that referenced
this pull request
Sep 11, 2024
Pull Request resolved: #5248 The upstream kernel uses this, I just didn't port it at first. ghstack-source-id: 242067824 @exported-using-ghexport Differential Revision: [D62154262](https://our.internmc.facebook.com/intern/diff/D62154262/)
Contributor
Author
|
apparently the threadpool is supposed to be optional at build time? |
…nel" The upstream kernel uses this, I just didn't port it at first. Differential Revision: [D62154262](https://our.internmc.facebook.com/intern/diff/D62154262/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62154262 |
swolchok
added a commit
that referenced
this pull request
Sep 11, 2024
Pull Request resolved: #5248 The upstream kernel uses this, I just didn't port it at first. ghstack-source-id: 242074917 @exported-using-ghexport Differential Revision: [D62154262](https://our.internmc.facebook.com/intern/diff/D62154262/)
…nel" The upstream kernel uses this, I just didn't port it at first. Differential Revision: [D62154262](https://our.internmc.facebook.com/intern/diff/D62154262/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62154262 |
swolchok
added a commit
that referenced
this pull request
Sep 11, 2024
Pull Request resolved: #5248 The upstream kernel uses this, I just didn't port it at first. ghstack-source-id: 242078299 @exported-using-ghexport Differential Revision: [D62154262](https://our.internmc.facebook.com/intern/diff/D62154262/)
…nel" The upstream kernel uses this, I just didn't port it at first. Differential Revision: [D62154262](https://our.internmc.facebook.com/intern/diff/D62154262/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62154262 |
build/cmake_deps.toml
Outdated
| ] | ||
| deps = [ | ||
| "executorch", | ||
| "pthreadpool", |
…nel" The upstream kernel uses this, I just didn't port it at first. Differential Revision: [D62154262](https://our.internmc.facebook.com/intern/diff/D62154262/) [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Sep 12, 2024
Pull Request resolved: #5248 The upstream kernel uses this, I just didn't port it at first. ghstack-source-id: 242278002 @exported-using-ghexport Differential Revision: [D62154262](https://our.internmc.facebook.com/intern/diff/D62154262/)
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62154262 |
…nel" The upstream kernel uses this, I just didn't port it at first. Differential Revision: [D62154262](https://our.internmc.facebook.com/intern/diff/D62154262/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62154262 |
swolchok
added a commit
that referenced
this pull request
Sep 12, 2024
Pull Request resolved: #5248 The upstream kernel uses this, I just didn't port it at first. ghstack-source-id: 242303807 @exported-using-ghexport Differential Revision: [D62154262](https://our.internmc.facebook.com/intern/diff/D62154262/)
…nel" The upstream kernel uses this, I just didn't port it at first. Differential Revision: [D62154262](https://our.internmc.facebook.com/intern/diff/D62154262/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62154262 |
swolchok
added a commit
that referenced
this pull request
Sep 12, 2024
Pull Request resolved: #5248 The upstream kernel uses this, I just didn't port it at first. ghstack-source-id: 242322409 @exported-using-ghexport Differential Revision: [D62154262](https://our.internmc.facebook.com/intern/diff/D62154262/)
…nel" The upstream kernel uses this, I just didn't port it at first. Differential Revision: [D62154262](https://our.internmc.facebook.com/intern/diff/D62154262/) [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Sep 13, 2024
Pull Request resolved: #5248 The upstream kernel uses this, I just didn't port it at first. ghstack-source-id: 242333678 @exported-using-ghexport Differential Revision: [D62154262](https://our.internmc.facebook.com/intern/diff/D62154262/)
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62154262 |
…nel" The upstream kernel uses this, I just didn't port it at first. Differential Revision: [D62154262](https://our.internmc.facebook.com/intern/diff/D62154262/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62154262 |
swolchok
added a commit
that referenced
this pull request
Sep 13, 2024
Pull Request resolved: #5248 The upstream kernel uses this, I just didn't port it at first. ghstack-source-id: 242411944 @exported-using-ghexport Differential Revision: [D62154262](https://our.internmc.facebook.com/intern/diff/D62154262/)
Contributor
|
This pull request has been merged in 6d1a573. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
The upstream kernel uses this, I just didn't port it at first.
Differential Revision: D62154262