[ExecuTorch] Preserve undelegated Linear ops in Llama demo export#5244
Closed
swolchok wants to merge 6 commits intogh/swolchok/53/basefrom
Closed
[ExecuTorch] Preserve undelegated Linear ops in Llama demo export#5244swolchok wants to merge 6 commits intogh/swolchok/53/basefrom
swolchok wants to merge 6 commits intogh/swolchok/53/basefrom
Conversation
Allows us to use optimized op_linear from the previous diff. Differential Revision: [D62262532](https://our.internmc.facebook.com/intern/diff/D62262532/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5244
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit faccc34 with merge base 3171ede ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62262532 |
This was referenced Sep 10, 2024
kimishpatel
approved these changes
Sep 10, 2024
… export" Allows us to use optimized op_linear from the previous diff. Differential Revision: [D62262532](https://our.internmc.facebook.com/intern/diff/D62262532/) [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Sep 11, 2024
Pull Request resolved: #5244 Allows us to use optimized op_linear from the previous diff. ghstack-source-id: 242001322 @exported-using-ghexport Differential Revision: [D62262532](https://our.internmc.facebook.com/intern/diff/D62262532/)
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62262532 |
… export" Allows us to use optimized op_linear from the previous diff. Differential Revision: [D62262532](https://our.internmc.facebook.com/intern/diff/D62262532/) [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Sep 11, 2024
Pull Request resolved: #5244 Allows us to use optimized op_linear from the previous diff. ghstack-source-id: 242004125 @exported-using-ghexport Differential Revision: [D62262532](https://our.internmc.facebook.com/intern/diff/D62262532/)
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62262532 |
… export" Allows us to use optimized op_linear from the previous diff. Differential Revision: [D62262532](https://our.internmc.facebook.com/intern/diff/D62262532/) [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Sep 11, 2024
Pull Request resolved: #5244 Allows us to use optimized op_linear from the previous diff. ghstack-source-id: 242011022 @exported-using-ghexport Differential Revision: [D62262532](https://our.internmc.facebook.com/intern/diff/D62262532/)
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62262532 |
… export" Allows us to use optimized op_linear from the previous diff. Differential Revision: [D62262532](https://our.internmc.facebook.com/intern/diff/D62262532/) [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Sep 11, 2024
Pull Request resolved: #5244 Allows us to use optimized op_linear from the previous diff. ghstack-source-id: 242013335 @exported-using-ghexport Differential Revision: [D62262532](https://our.internmc.facebook.com/intern/diff/D62262532/)
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62262532 |
… export" Allows us to use optimized op_linear from the previous diff. Differential Revision: [D62262532](https://our.internmc.facebook.com/intern/diff/D62262532/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62262532 |
swolchok
added a commit
that referenced
this pull request
Sep 11, 2024
Pull Request resolved: #5244 Allows us to use optimized op_linear from the previous diff. ghstack-source-id: 242061030 @exported-using-ghexport Differential Revision: [D62262532](https://our.internmc.facebook.com/intern/diff/D62262532/)
Contributor
|
This pull request has been merged in 12a25c6. |
swolchok
added a commit
to swolchok/executorch
that referenced
this pull request
Sep 12, 2024
Summary: pytorch#5244 probably broke it, because it makes optimized ops a requirement to run llama without xnnpack. Test Plan: `bash .ci/scripts/test_model.sh llama2 cmake portable` was broken and now succeeds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Allows us to use optimized op_linear from the previous diff.
Differential Revision: D62262532