Skip to content

migrate sparsify_ to configs#1856

Merged
vkuzo merged 50 commits intomainfrom
gh/vkuzo/60/head
Mar 12, 2025
Merged

migrate sparsify_ to configs#1856
vkuzo merged 50 commits intomainfrom
gh/vkuzo/60/head

Conversation

@vkuzo
Copy link
Copy Markdown
Contributor

@vkuzo vkuzo commented Mar 7, 2025 •
edited
Loading

Summary:

Before:

sparsify_(model, semi_sparse_weight())
sparsify_(model, block_sparse_weight(64))

After:

# new syntax
sparsify_(model, SemiSparseWeightConfig())
sparsify_(model, BlockSparseWeightConfig(64))

# old syntax still works
sparsify_(model, semi_sparse_weight())
sparsify_(model, block_sparse_weight(64))

Test Plan:

pytest test/sparsity/test_sparse_api.py -s -x

Reviewers:

Subscribers:

Tasks:

Tags:

vkuzo added 7 commits March 7, 2025 06:48
@vkuzo
Update
73ea701 
[ghstack-poisoned]
@vkuzo
Update
4f2c69d 
[ghstack-poisoned]
@vkuzo
Update
75fb698 
[ghstack-poisoned]
@vkuzo
Update
5796efc 
[ghstack-poisoned]
@vkuzo
Update
3b016e7 
[ghstack-poisoned]
@vkuzo
Update
11bce08 
[ghstack-poisoned]
@vkuzo
Update
3a91a06 
[ghstack-poisoned]
@vkuzo
Copy link
Copy Markdown
Contributor Author

vkuzo commented Mar 7, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Mar 7, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1856

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@vkuzo vkuzo mentioned this pull request Mar 7, 2025
Merged
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 7, 2025
This was referenced Mar 7, 2025
Merged
Merged
Merged
Merged
vkuzo added a commit that referenced this pull request Mar 7, 2025
@vkuzo
migrate sparsify_ to configs
d3335e2 
Summary:

Before:

```python
sparsify_(model, semi_sparse_weight())
sparsify_(model, block_sparse_weight(64))
```

After:

```
sparsify_(model, SemiSparseWeightConfig())
sparsify_(model, BlockSparseWeightConfig(64))

sparsify_(model, semi_sparse_weight())
sparsify_(model, block_sparse_weight(64))
```

Test Plan:

```
pytest test/sparsity/test_sparse_api.py -s -x
```

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: dc9dd9d
ghstack-comment-id: 2706995209
Pull Request resolved: #1856
@vkuzo vkuzo added the topic: improvement Use this tag if this PR is an improvement (doesn't fit into any of the other categories) label Mar 7, 2025
@vkuzo vkuzo mentioned this pull request Mar 7, 2025
Merged
vkuzo added 4 commits March 7, 2025 09:51
@vkuzo
Update
125546b 
[ghstack-poisoned]
@vkuzo
Update
130a52e 
[ghstack-poisoned]
@vkuzo
Update
70e0e53 
[ghstack-poisoned]
@vkuzo
Update
049d750 
[ghstack-poisoned]
This was referenced Mar 7, 2025
Merged
Closed
vkuzo added 5 commits March 7, 2025 10:42
@vkuzo
Update
1ea0e2f 
[ghstack-poisoned]
@vkuzo
Update
cf3ad33 
[ghstack-poisoned]
@vkuzo
Update
19ac99d 
[ghstack-poisoned]
@vkuzo
Update
5deed22 
[ghstack-poisoned]
@vkuzo
Update
2a1f7b2 
[ghstack-poisoned]
vkuzo added 2 commits March 8, 2025 06:15
@vkuzo
Update
6f1c92d 
[ghstack-poisoned]
@vkuzo
Update
95be23e 
[ghstack-poisoned]
@vkuzo vkuzo changed the base branch from gh/vkuzo/58/head to gh/vkuzo/59/head March 8, 2025 14:15
vkuzo added 14 commits March 8, 2025 12:16
@vkuzo
Update
fdb292e 
[ghstack-poisoned]
@vkuzo
Update
706ff1f 
[ghstack-poisoned]
@vkuzo
Update
ac2314e 
[ghstack-poisoned]
@vkuzo
Update
8002c39 
[ghstack-poisoned]
@vkuzo
Update
a4dfaa1 
[ghstack-poisoned]
@vkuzo
Update
0506d32 
[ghstack-poisoned]
@vkuzo
Update
237a72a 
[ghstack-poisoned]
@vkuzo
Update
7183e83 
[ghstack-poisoned]
@vkuzo
Update
10d0dff 
[ghstack-poisoned]
@vkuzo
Update
2ec7827 
[ghstack-poisoned]
@vkuzo
Update
3f10bc5 
[ghstack-poisoned]
@vkuzo
Update
fa8c0f1 
[ghstack-poisoned]
@vkuzo
Update
50a7f9f 
[ghstack-poisoned]
@vkuzo
Update
8c8d7e4 
[ghstack-poisoned]
@vkuzo vkuzo mentioned this pull request Mar 10, 2025
Merged
vkuzo added 2 commits March 10, 2025 15:47
@vkuzo
Update
34ce5f4 
[ghstack-poisoned]
@vkuzo
Update
c038451 
[ghstack-poisoned]
@vkuzo vkuzo mentioned this pull request Mar 10, 2025
Merged
@vkuzo
Update
4f195b6 
[ghstack-poisoned]
This was referenced Mar 11, 2025
Merged
Closed
vkuzo added 3 commits March 12, 2025 10:17
@vkuzo
Update
db3e3d3 
[ghstack-poisoned]
@vkuzo
Update
5f742de 
[ghstack-poisoned]
@vkuzo
Update
bdf1aea 
[ghstack-poisoned]
@vkuzo vkuzo changed the base branch from gh/vkuzo/59/head to main March 12, 2025 20:56
@vkuzo vkuzo merged commit 83a2e28 into main Mar 12, 2025
liangel-02 pushed a commit that referenced this pull request Aug 25, 2025
@vkuzo @liangel-02
migrate sparsify_ to configs (#1856)
b813681 
* Update

[ghstack-poisoned]

* Update

[ghstack-poisoned]

* Update

[ghstack-poisoned]

* Update

[ghstack-poisoned]

* Update

[ghstack-poisoned]

* Update

[ghstack-poisoned]

* Update

[ghstack-poisoned]

* Update

[ghstack-poisoned]

* Update

[ghstack-poisoned]

* Update

[ghstack-poisoned]

* Update

[ghstack-poisoned]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jcaip jcaip jcaip approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: improvement Use this tag if this PR is an improvement (doesn't fit into any of the other categories)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vkuzo @jcaip @facebook-github-bot