Skip to content

enforce AOBaseConfig type in quantize_'s config argument#1861

Merged
vkuzo merged 88 commits intomainfrom
gh/vkuzo/64/head
Mar 12, 2025
Merged

enforce AOBaseConfig type in quantize_'s config argument#1861
vkuzo merged 88 commits intomainfrom
gh/vkuzo/64/head

Conversation

@vkuzo
Copy link
Copy Markdown
Contributor

@vkuzo vkuzo commented Mar 10, 2025 •
edited
Loading

Summary:

Finishing the migration in #1690. After this PR, AOBaseConfig is the only way to configure a workflow to be used in quantize_.

Before

def quantize_(
    model: torch.nn.Module,
    config: Union[AOBaseConfig, Callable[[torch.nn.Module], torch.nn.Module]],
    filter_fn: Optional[Callable[[torch.nn.Module, str], bool]] = None,
    set_inductor_config: Optional[bool] = None,
    device: Optional[torch.types.Device] = None,
):

After

def quantize_(
    model: torch.nn.Module,
    config: AOBaseConfig,
    filter_fn: Optional[Callable[[torch.nn.Module, str], bool]] = None,
    set_inductor_config: Optional[bool] = None,
    device: Optional[torch.types.Device] = None,
):

Test Plan: CI

Reviewers:

Subscribers:

Tasks:

Tags:

vkuzo added 30 commits March 7, 2025 06:48
@vkuzo
Update
73ea701 
[ghstack-poisoned]
@vkuzo
Update
4f2c69d 
[ghstack-poisoned]
@vkuzo
Update
75fb698 
[ghstack-poisoned]
@vkuzo
Update
5796efc 
[ghstack-poisoned]
@vkuzo
Update
3b016e7 
[ghstack-poisoned]
@vkuzo
Update
11bce08 
[ghstack-poisoned]
@vkuzo
Update
3a91a06 
[ghstack-poisoned]
@vkuzo
Update
91c350f 
[ghstack-poisoned]
@vkuzo
Update
125546b 
[ghstack-poisoned]
@vkuzo
Update
130a52e 
[ghstack-poisoned]
@vkuzo
Update
70e0e53 
[ghstack-poisoned]
@vkuzo
Update
049d750 
[ghstack-poisoned]
@vkuzo
Update
7b8fb8d 
[ghstack-poisoned]
@vkuzo
Update
74965d3 
[ghstack-poisoned]
@vkuzo
Update
1ea0e2f 
[ghstack-poisoned]
@vkuzo
Update
03ea2e4 
[ghstack-poisoned]
@vkuzo
Update
9d7210b 
[ghstack-poisoned]
@vkuzo
Update
cf3ad33 
[ghstack-poisoned]
@vkuzo
Update
19ac99d 
[ghstack-poisoned]
@vkuzo
Update
5deed22 
[ghstack-poisoned]
@vkuzo
Update
2a1f7b2 
[ghstack-poisoned]
@vkuzo
Update
5fa0e27 
[ghstack-poisoned]
@vkuzo
Update
160cc29 
[ghstack-poisoned]
@vkuzo
Update
7e40b15 
[ghstack-poisoned]
@vkuzo
Update
b0a32c3 
[ghstack-poisoned]
@vkuzo
Update
0ecb02d 
[ghstack-poisoned]
@vkuzo
Update
7cb810c 
[ghstack-poisoned]
@vkuzo
Update
eb567cd 
[ghstack-poisoned]
@vkuzo
Update
cd97b30 
[ghstack-poisoned]
@vkuzo
Update
de38b6e 
[ghstack-poisoned]
vkuzo added 5 commits March 10, 2025 15:47
@vkuzo
Update
34ce5f4 
[ghstack-poisoned]
@vkuzo
Update
c038451 
[ghstack-poisoned]
@vkuzo
Update
c3815dc 
[ghstack-poisoned]
@vkuzo
Update
9280bc9 
[ghstack-poisoned]
@vkuzo
Update
fd5cfc0 
[ghstack-poisoned]
This was referenced Mar 10, 2025
Merged
Closed
vkuzo added 4 commits March 10, 2025 16:04
@vkuzo
Update
4f195b6 
[ghstack-poisoned]
@vkuzo
Update
0d388c8 
[ghstack-poisoned]
@vkuzo
Update
42f323f 
[ghstack-poisoned]
@vkuzo
Update
0a9fc76 
[ghstack-poisoned]
vkuzo added 15 commits March 12, 2025 10:17
@vkuzo
Update
db3e3d3 
[ghstack-poisoned]
@vkuzo
Update
5f742de 
[ghstack-poisoned]
@vkuzo
Update
6500a26 
[ghstack-poisoned]
@vkuzo
Update
8d16b60 
[ghstack-poisoned]
@vkuzo
Update
3d32932 
[ghstack-poisoned]
@vkuzo
Update
bdf1aea 
[ghstack-poisoned]
@vkuzo
Update
c2577a2 
[ghstack-poisoned]
@vkuzo
Update
902f8fa 
[ghstack-poisoned]
@vkuzo
Update
a7369a7 
[ghstack-poisoned]
@vkuzo
Update
82b6281 
[ghstack-poisoned]
@vkuzo
Update
34bfd94 
[ghstack-poisoned]
@vkuzo
Update
32d29f0 
[ghstack-poisoned]
@vkuzo
Update
b63f186 
[ghstack-poisoned]
@vkuzo
Update
4abb545 
[ghstack-poisoned]
@vkuzo
Update
2c6104a 
[ghstack-poisoned]
@vkuzo vkuzo changed the base branch from gh/vkuzo/62/head to main March 12, 2025 20:59
@vkuzo vkuzo merged commit 28d68e2 into main Mar 12, 2025
liangel-02 pushed a commit that referenced this pull request Aug 25, 2025
@vkuzo @liangel-02
enforce AOBaseConfig type in quantize_'s config argument (#1861)
d1de8aa 
* Update

[ghstack-poisoned]

* Update

[ghstack-poisoned]

* Update

[ghstack-poisoned]

* Update

[ghstack-poisoned]

* Update

[ghstack-poisoned]

* Update

[ghstack-poisoned]

* Update

[ghstack-poisoned]

* Update

[ghstack-poisoned]

* Update

[ghstack-poisoned]

* Update

[ghstack-poisoned]

* Update

[ghstack-poisoned]

* Update

[ghstack-poisoned]

* Update

[ghstack-poisoned]

* Update

[ghstack-poisoned]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewor14 andrewor14 andrewor14 approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: bc-breaking Use this tag if this PR breaks backward compatibility

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vkuzo @andrewor14 @facebook-github-bot