Skip to content

remove the set_inductor_config argument of quantize_.#1865

Merged
vkuzo merged 96 commits intomainfrom
gh/vkuzo/65/head
Mar 12, 2025
Merged

remove the set_inductor_config argument of quantize_.#1865
vkuzo merged 96 commits intomainfrom
gh/vkuzo/65/head

Conversation

@vkuzo
Copy link
Copy Markdown
Contributor

@vkuzo vkuzo commented Mar 10, 2025 •
edited
Loading

Summary:

Finishing the migration in #1715. Specifically:

  • the set_inductor_config argument of quantize_ is removed
  • the following workflows get a set_inductor_config argument, defaulting to True: AWQUIntXConfig, IntNWeightOnlyConfig, SmoothQuantConfig, Int8DynamicActivationInt4WeightConfig, Int4DynamicActivationInt4WeightConfig, GemliteUIntXWeightOnlyConfig, Int4WeightOnlyConfig, Int8WeightOnlyConfig, Int8DynamicActivationInt8WeightConfig, Float8WeightOnlyConfig, Float8DynamicActivationFloat8WeightConfig, Float8DynamicActivationFloat8WeightConfig, Float8StaticActivationFloat8WeightConfig, Float8StaticActivationFloat8WeightConfig, UIntXWeightOnlyConfig, FPXWeightOnlyConfig. I skipped quantized training and non-AQT workflows from this, since I expect them to not need this setting.

Before

def quantize_(
    model: torch.nn.Module,
    config: AOBaseConfig,
    filter_fn: Optional[Callable[[torch.nn.Module, str], bool]] = None,
    set_inductor_config: Optional[bool] = None,
    device: Optional[torch.types.Device] = None,
):  ...

After

def quantize_(
    model: torch.nn.Module,
    config: AOBaseConfig,
    filter_fn: Optional[Callable[[torch.nn.Module, str], bool]] = None,
    device: Optional[torch.types.Device] = None,
):  ...

# see top of PR description for list of affected configs
class Int8DynamicActivationInt4WeightConfig(AOBaseConfig):
    ...
    set_inductor_config: bool = True

Test Plan:

pytest test/quantization/test_quant_api.py -s -x -k test_workflow_e2e_numerics

Reviewers:

Subscribers:

Tasks:

Tags:

vkuzo added 30 commits March 7, 2025 06:48
@vkuzo
Update
73ea701 
[ghstack-poisoned]
@vkuzo
Update
4f2c69d 
[ghstack-poisoned]
@vkuzo
Update
75fb698 
[ghstack-poisoned]
@vkuzo
Update
5796efc 
[ghstack-poisoned]
@vkuzo
Update
3b016e7 
[ghstack-poisoned]
@vkuzo
Update
11bce08 
[ghstack-poisoned]
@vkuzo
Update
3a91a06 
[ghstack-poisoned]
@vkuzo
Update
91c350f 
[ghstack-poisoned]
@vkuzo
Update
125546b 
[ghstack-poisoned]
@vkuzo
Update
130a52e 
[ghstack-poisoned]
@vkuzo
Update
70e0e53 
[ghstack-poisoned]
@vkuzo
Update
049d750 
[ghstack-poisoned]
@vkuzo
Update
7b8fb8d 
[ghstack-poisoned]
@vkuzo
Update
74965d3 
[ghstack-poisoned]
@vkuzo
Update
1ea0e2f 
[ghstack-poisoned]
@vkuzo
Update
03ea2e4 
[ghstack-poisoned]
@vkuzo
Update
9d7210b 
[ghstack-poisoned]
@vkuzo
Update
cf3ad33 
[ghstack-poisoned]
@vkuzo
Update
19ac99d 
[ghstack-poisoned]
@vkuzo
Update
5deed22 
[ghstack-poisoned]
@vkuzo
Update
2a1f7b2 
[ghstack-poisoned]
@vkuzo
Update
5fa0e27 
[ghstack-poisoned]
@vkuzo
Update
160cc29 
[ghstack-poisoned]
@vkuzo
Update
7e40b15 
[ghstack-poisoned]
@vkuzo
Update
b0a32c3 
[ghstack-poisoned]
@vkuzo
Update
0ecb02d 
[ghstack-poisoned]
@vkuzo
Update
7cb810c 
[ghstack-poisoned]
@vkuzo
Update
eb567cd 
[ghstack-poisoned]
@vkuzo
Update
cd97b30 
[ghstack-poisoned]
@vkuzo
Update
de38b6e 
[ghstack-poisoned]
vkuzo added 3 commits March 12, 2025 10:17
@vkuzo
Update
8d16b60 
[ghstack-poisoned]
@vkuzo
Update
3d32932 
[ghstack-poisoned]
@vkuzo
Update
606a60f 
[ghstack-poisoned]
vkuzo added a commit that referenced this pull request Mar 12, 2025
@vkuzo
remove the set_inductor_config argument of quantize_.
ca5358d 
Summary:

Test Plan:

```
pytest test/quantization/test_quant_api.py -s -x -k test_workflow_e2e_numerics
```

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: e6694cc
ghstack-comment-id: 2712016215
Pull Request resolved: #1865
vkuzo added 5 commits March 12, 2025 13:56
@vkuzo
Update
bdf1aea 
[ghstack-poisoned]
@vkuzo
Update
c2577a2 
[ghstack-poisoned]
@vkuzo
Update
902f8fa 
[ghstack-poisoned]
@vkuzo
Update
a7369a7 
[ghstack-poisoned]
@vkuzo
Update
6c9cffe 
[ghstack-poisoned]
vkuzo added a commit that referenced this pull request Mar 12, 2025
@vkuzo
remove the set_inductor_config argument of quantize_.
f65e5d4 
Summary:

Test Plan:

```
pytest test/quantization/test_quant_api.py -s -x -k test_workflow_e2e_numerics
```

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: e6694cc
ghstack-comment-id: 2712016215
Pull Request resolved: #1865
vkuzo added 4 commits March 12, 2025 13:57
@vkuzo
Update
82b6281 
[ghstack-poisoned]
@vkuzo
Update
34bfd94 
[ghstack-poisoned]
@vkuzo
Update
32d29f0 
[ghstack-poisoned]
@vkuzo
Update
3675f78 
[ghstack-poisoned]
vkuzo added a commit that referenced this pull request Mar 12, 2025
@vkuzo
remove the set_inductor_config argument of quantize_.
f0a3372 
Summary:

Test Plan:

```
pytest test/quantization/test_quant_api.py -s -x -k test_workflow_e2e_numerics
```

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: e6694cc
ghstack-comment-id: 2712016215
Pull Request resolved: #1865
vkuzo added 3 commits March 12, 2025 13:58
@vkuzo
Update
b63f186 
[ghstack-poisoned]
@vkuzo
Update
4abb545 
[ghstack-poisoned]
@vkuzo
Update
4e7c5c2 
[ghstack-poisoned]
vkuzo added a commit that referenced this pull request Mar 12, 2025
@vkuzo
remove the set_inductor_config argument of quantize_.
c4c0dd1 
Summary:

Test Plan:

```
pytest test/quantization/test_quant_api.py -s -x -k test_workflow_e2e_numerics
```

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: e6694cc
ghstack-comment-id: 2712016215
Pull Request resolved: #1865
vkuzo added 2 commits March 12, 2025 13:59
@vkuzo
Update
2c6104a 
[ghstack-poisoned]
@vkuzo
Update
67100e9 
[ghstack-poisoned]
vkuzo added a commit that referenced this pull request Mar 12, 2025
@vkuzo
remove the set_inductor_config argument of quantize_.
7f16377 
Summary:

Test Plan:

```
pytest test/quantization/test_quant_api.py -s -x -k test_workflow_e2e_numerics
```

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: e6694cc
ghstack-comment-id: 2712016215
Pull Request resolved: #1865
@vkuzo
Update
a28c5e4 
[ghstack-poisoned]
@vkuzo vkuzo changed the base branch from gh/vkuzo/64/head to main March 12, 2025 20:59
vkuzo added a commit that referenced this pull request Mar 12, 2025
@vkuzo
remove the set_inductor_config argument of quantize_.
7538fdc 
Summary:

Test Plan:

```
pytest test/quantization/test_quant_api.py -s -x -k test_workflow_e2e_numerics
```

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: e6694cc
ghstack-comment-id: 2712016215
Pull Request resolved: #1865
@vkuzo vkuzo merged commit 0eea64a into main Mar 12, 2025
tfqaprod pushed a commit to intel/ai-reference-models that referenced this pull request Mar 13, 2025
@sanchitintel @sramakintel
Modify LLaMA inference script to adapt the code to torchao main branc…
4855b7a 
…h (#2681)

In pytorch/ao#1865, torchao removed `set_inductor_config` argument from `torchao.quantization.quant_api.quantize_`

Co-authored-by: Srikanth Ramakrishna <srikanth.ramakrishna@intel.com>
@jerryzh168 jerryzh168 mentioned this pull request Jun 4, 2025
Open
liangel-02 pushed a commit that referenced this pull request Aug 25, 2025
@vkuzo @liangel-02
remove the set_inductor_config argument of quantize_. (#1865)
5d709ed 
* Update

[ghstack-poisoned]

* Update

[ghstack-poisoned]

* Update

[ghstack-poisoned]

* Update

[ghstack-poisoned]

* Update

[ghstack-poisoned]

* Update

[ghstack-poisoned]

* Update

[ghstack-poisoned]

* Update

[ghstack-poisoned]

* Update

[ghstack-poisoned]

* Update

[ghstack-poisoned]

* Update

[ghstack-poisoned]

* Update

[ghstack-poisoned]

* Update

[ghstack-poisoned]

* Update

[ghstack-poisoned]

* Update

[ghstack-poisoned]
claynerobison pushed a commit to intel/ai-reference-models that referenced this pull request Dec 30, 2025
@sanchitintel @sramakintel
Modify LLaMA inference script to adapt the code to torchao main branc…
660c1ea 
…h (#2681)

In pytorch/ao#1865, torchao removed `set_inductor_config` argument from `torchao.quantization.quant_api.quantize_`

Co-authored-by: Srikanth Ramakrishna <srikanth.ramakrishna@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewor14 andrewor14 andrewor14 approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: bc-breaking Use this tag if this PR breaks backward compatibility

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vkuzo @andrewor14 @facebook-github-bot