Add a python 3.7+ version of Annotated to typing_extensions (#1014)#632
Add a python 3.7+ version of Annotated to typing_extensions (#1014)#632ilevkivskyi merged 7 commits intopython:masterfrom till-varoquaux:master
Conversation
ilevkivskyi
left a comment
There was a problem hiding this comment.
Thanks for quick implementation! This looks good. I have some suggestions (mostly minor and stylistic).
Shouldn't this also add a "patched" version of get_type_hints() that would work as described in the PEP?
|
Since I'm new to this code base I'm proceeding very incrementally. The get_type_hints diffs will come in a separate batch. |
Co-Authored-By: Ivan Levkivskyi <levkivskyi@gmail.com>
Co-Authored-By: Ivan Levkivskyi <levkivskyi@gmail.com>
Co-Authored-By: Ivan Levkivskyi <levkivskyi@gmail.com>
ilevkivskyi
left a comment
There was a problem hiding this comment.
Great! I have few more small comments, otherwise this is ready to be merged.
|
Ok, we should be ready to go! Thank you Ivan and Jakub for your all of your feedback. If you want I can squash all of those commits before we merge this request. |
|
We always squash ourselves, please don't do this. You can now post in the PEP discussion thread and propose people to try this out and play with it (one can install the library direcrly from GitHub). |
The code has been added to typing_extensions in python/typing#632 and python/typing#639. I really didn't know how to type Annotated and _AnnotatedAlias here – feel free to correct this.
The code has been added to typing_extensions in python/typing#632 and python/typing#639.
First commits for PEP 593..