Pep 593 py3#639
Merged
ilevkivskyi merged 4 commits intopython:masterfrom Jun 5, 2019
till-varoquaux:pep-593-py3
Merged
Conversation
ilevkivskyi
reviewed
Jun 2, 2019
Member
On the "Files changed tab" there is a little gear icon just above the diff, click on it, and check the box "Ignore whitespace". |
ilevkivskyi
reviewed
Jun 4, 2019
Member
ilevkivskyi
left a comment
There was a problem hiding this comment.
Thanks for updates! This is almost ready, I have few more comments.
| raise TypeError("Annotated cannot be used with isinstance().") | ||
|
|
||
| def __subclasscheck__(self, cls): | ||
| raise TypeError("Annotated cannot be used with issubclass().") |
Member
There was a problem hiding this comment.
You marked this as resolved, but nothing has changed here, only in the other version (where it is actually more clear).
ilevkivskyi
approved these changes
Jun 5, 2019
Member
ilevkivskyi
left a comment
There was a problem hiding this comment.
Thanks for updates! LGTM now.
jstasiak
added a commit
to jstasiak/typeshed
that referenced
this pull request
Oct 15, 2019
The code has been added to typing_extensions in python/typing#632 and python/typing#639. I really didn't know how to type Annotated and _AnnotatedAlias here – feel free to correct this.
JelleZijlstra
pushed a commit
to python/typeshed
that referenced
this pull request
Oct 16, 2019
The code has been added to typing_extensions in python/typing#632 and python/typing#639.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This covers python 3.53 and above. I added a fair amount of tests; this diff is hard to read in this interface because it doesn't seem to offer a way to ignore whitespaces.