Skip to content

Add a minimal setup.py file to typing_extensions#1014

Closed
hoodmane wants to merge 1 commit intopython:masterfrom
hoodmane:typing-extensions-minimal-setup.py
Closed

Add a minimal setup.py file to typing_extensions#1014
hoodmane wants to merge 1 commit intopython:masterfrom
hoodmane:typing-extensions-minimal-setup.py

Conversation

@hoodmane
Copy link

@hoodmane hoodmane commented Jan 7, 2022

For some purposes it's useful to have a setup.py file. I think this is the correct way to have setup.py defer to pyproject.toml.

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@hoodmane

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@srittau
Copy link
Collaborator

srittau commented Jan 7, 2022

What situations are those? Please also note that typing_extensions is not built using setuptools, but is using flit.

@hoodmane
Copy link
Author

hoodmane commented Jan 8, 2022

Well I wanted to use it for building with Pyodide which is currently hard coded to try to use setup.py. In the case of typing-extensions, we don't need to patch it and it is pure Python, so we should just distribute the typing_extensions wheel from PyPI. More generally, we probably will have to switch to handling packages built with these different build systems. For now we can just inject this file into typing_extensions as the laziest possible fix.

I don't really understand the situation with Python packaging with setup.py and setup.cfg and pyproject.toml and poetry and flit and meson, etc, etc.

I guess I will close this, since it makes more sense for us to fix our build system downstream.

@hoodmane hoodmane closed this Jan 8, 2022
@srittau
Copy link
Collaborator

srittau commented Jan 8, 2022

I don't really understand the situation with Python packaging with setup.py and setup.cfg and pyproject.toml and poetry and flit and meson, etc, etc.

No one does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants