Skip to content

BUG: _get_fonts not processing properly CIDFonts and annotations#2194

Merged
MartinThoma merged 3 commits intopy-pdf:mainfrom
pubpub-zz:iss2192
Sep 17, 2023
Merged

BUG: _get_fonts not processing properly CIDFonts and annotations#2194
MartinThoma merged 3 commits intopy-pdf:mainfrom
pubpub-zz:iss2192

Conversation

@pubpub-zz
Copy link
Copy Markdown
Collaborator

closes #2192

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 16, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (b899d3d) 94.36% compared to head (8f7ee99) 94.37%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2194      +/-   ##
==========================================
+ Coverage   94.36%   94.37%   +0.01%     
==========================================
  Files          43       43              
  Lines        7572     7586      +14     
  Branches     1488     1496       +8     
==========================================
+ Hits         7145     7159      +14     
  Misses        263      263              
  Partials      164      164              
Files Changed Coverage Δ
pypdf/_page.py 94.15% <100.00%> (+0.09%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pubpub-zz
Copy link
Copy Markdown
Collaborator Author

@MartinThoma
all yours

@MartinThoma MartinThoma merged commit ea64f5b into py-pdf:main Sep 17, 2023
@MartinThoma
Copy link
Copy Markdown
Member

Thank you :-)

MartinThoma added a commit that referenced this pull request Sep 17, 2023
## What's new

### Bug Fixes (BUG)
-  Missing new line in extract_text with cm operations (#2142) by @pubpub-zz
-  _get_fonts not processing properly CIDFonts and annotations (#2194) by @pubpub-zz

### Documentation (DOC)
-  Sort list of contributors by @MartinThoma

### Developer Experience (DEV)
-  Give attribution in release notes (#2196) by @MartinThoma

### Maintenance (MAINT)
-  Update packages (#2195) by @MartinThoma
-  Rename PdfWriter.create_viewer_preferences to PdfWriter.create_viewer_preferences (#2190) by @marcstober
-  Mark `cryptography` as default (#2186) by @exiledkingcc

### Testing (TST)
-  Issue with merging pdfkit (#2191) by @MartinThoma

### Code Style (STY)
-   clean-up overriden variable (#2189) by @pubpub-zz

[Full Changelog](3.16.0...3.16.1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PageObject._get_fonts() returns embedded as unembedded.

2 participants