Skip to content

MAINT: Rename PdfWriter.create_viewer_preferences to PdfWriter.create_viewer_preferences#2190

Merged
MartinThoma merged 3 commits intopy-pdf:mainfrom
marcstober:viewerpreferencesdocs
Sep 15, 2023
Merged

MAINT: Rename PdfWriter.create_viewer_preferences to PdfWriter.create_viewer_preferences#2190
MartinThoma merged 3 commits intopy-pdf:mainfrom
marcstober:viewerpreferencesdocs

Conversation

@marcstober
Copy link
Copy Markdown
Contributor

@marcstober marcstober commented Sep 13, 2023

Add documentation and fix a method name as discussed in #2105

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 13, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (c587cee) 94.34% compared to head (291b812) 94.36%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2190      +/-   ##
==========================================
+ Coverage   94.34%   94.36%   +0.01%     
==========================================
  Files          43       43              
  Lines        7572     7572              
  Branches     1488     1488              
==========================================
+ Hits         7144     7145       +1     
  Misses        263      263              
+ Partials      165      164       -1     
Files Changed Coverage Δ
pypdf/generic/_viewerpref.py 100.00% <ø> (ø)
pypdf/_writer.py 88.34% <100.00%> (+0.08%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MartinThoma MartinThoma changed the title Viewer Preferences docs and method rename MAINT: Rename PdfWriter.create_viewer_preferences to PdfWriter.create_viewer_preferences Sep 15, 2023
@MartinThoma MartinThoma merged commit b899d3d into py-pdf:main Sep 15, 2023
MartinThoma added a commit that referenced this pull request Sep 17, 2023
## What's new

### Bug Fixes (BUG)
-  Missing new line in extract_text with cm operations (#2142) by @pubpub-zz
-  _get_fonts not processing properly CIDFonts and annotations (#2194) by @pubpub-zz

### Documentation (DOC)
-  Sort list of contributors by @MartinThoma

### Developer Experience (DEV)
-  Give attribution in release notes (#2196) by @MartinThoma

### Maintenance (MAINT)
-  Update packages (#2195) by @MartinThoma
-  Rename PdfWriter.create_viewer_preferences to PdfWriter.create_viewer_preferences (#2190) by @marcstober
-  Mark `cryptography` as default (#2186) by @exiledkingcc

### Testing (TST)
-  Issue with merging pdfkit (#2191) by @MartinThoma

### Code Style (STY)
-   clean-up overriden variable (#2189) by @pubpub-zz

[Full Changelog](3.16.0...3.16.1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants