BUG: Missing new line in extract_text with cm operations#2142
BUG: Missing new line in extract_text with cm operations#2142MartinThoma merged 8 commits intopy-pdf:mainfrom
Conversation
|
@MartinThoma |
thread_time not available in python 3.6
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2142 +/- ##
=======================================
Coverage 94.36% 94.36%
=======================================
Files 43 43
Lines 7572 7574 +2
Branches 1488 1488
=======================================
+ Hits 7145 7147 +2
Misses 263 263
Partials 164 164
☔ View full report in Codecov by Sentry. |
|
@MartinThoma all yours. a rerun of the extract_text benchmark could be interesting |
|
Re-running the CI should be as easy as going to the corresponding CI run at https://github.com/py-pdf/pypdf/actions and clicking "Re-run all jobs" in the upper right corner, given the correct repository permissions. |
|
This permission seems to be granted only to a limited of people.🫤 |
|
|
||
|
|
||
| @pytest.mark.enable_socket() | ||
| @pytest.mark.timeout(4) # this was a lot slower before PR #2086 |
There was a problem hiding this comment.
I think that one is the cleaner option. If we change it, it should be a separate PR (but I'm uncertain if we should change it at all).
You mentioned that you had issues with that test. Was it local or in CI? What exactly was the issue / the error message?
There was a problem hiding this comment.
I agree it is not the good place, but wanted to discuss about.
The issue during the checks was just it failed with the timeout. It is not the first time this is why I've proposed this change.
I consider the time is ok but for me it is just because We are measuring too many instructions. That' why I've focused on the specif code of the merge.
If you like it just give me a go and I will generate a dedicated PR dealing with this change only
|
@MartinThoma |
|
@pubpub-zz Sorry for the delay. The Could you please remove the changes from |
|
Besides |
|
@MartinThoma |
|
Thank you 🙏 I noticed that when I have a lot to do at work, I have a harder time taking decisions in my private life (including pypdf). Keeping PRs about one issue makes it easier for me 🙏 |
## What's new ### Bug Fixes (BUG) - Missing new line in extract_text with cm operations (#2142) by @pubpub-zz - _get_fonts not processing properly CIDFonts and annotations (#2194) by @pubpub-zz ### Documentation (DOC) - Sort list of contributors by @MartinThoma ### Developer Experience (DEV) - Give attribution in release notes (#2196) by @MartinThoma ### Maintenance (MAINT) - Update packages (#2195) by @MartinThoma - Rename PdfWriter.create_viewer_preferences to PdfWriter.create_viewer_preferences (#2190) by @marcstober - Mark `cryptography` as default (#2186) by @exiledkingcc ### Testing (TST) - Issue with merging pdfkit (#2191) by @MartinThoma ### Code Style (STY) - clean-up overriden variable (#2189) by @pubpub-zz [Full Changelog](3.16.0...3.16.1)
closes #2138