Skip to content

ROB: Improve tolerance to invalid Names/Dests#1658

Merged
MartinThoma merged 3 commits intopy-pdf:mainfrom
pubpub-zz:iss1652
Feb 25, 2023
Merged

ROB: Improve tolerance to invalid Names/Dests#1658
MartinThoma merged 3 commits intopy-pdf:mainfrom
pubpub-zz:iss1652

Conversation

@pubpub-zz
Copy link
Collaborator

fixes #1652

@pubpub-zz
Copy link
Collaborator Author

for testing :
invalidNamesDest.pdf

@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Base: 91.92% // Head: 91.93% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (d725d40) compared to base (0e0b943).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1658      +/-   ##
==========================================
+ Coverage   91.92%   91.93%   +0.01%     
==========================================
  Files          33       33              
  Lines        6375     6383       +8     
  Branches     1272     1273       +1     
==========================================
+ Hits         5860     5868       +8     
  Misses        327      327              
  Partials      188      188              
Impacted Files Coverage Δ
pypdf/_reader.py 90.49% <100.00%> (+0.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pubpub-zz
Copy link
Collaborator Author

@MartinThoma
all yours 🙂

@MartinThoma MartinThoma changed the title ROB : improve tolerance to invalid Names/Dests ROB: Improve tolerance to invalid Names/Dests Feb 25, 2023
@MartinThoma MartinThoma added is-robustness-issue From a users perspective, this is about robustness PdfReader The PdfReader component is affected labels Feb 25, 2023
@MartinThoma MartinThoma merged commit 5b4bb27 into py-pdf:main Feb 25, 2023
MartinThoma added a commit that referenced this pull request Feb 26, 2023
New Features (ENH)
-  Add reader.attachments public interface (#1611, #1661)
-  Add PdfWriter.remove_objects_from_page(page: PageObject, to_delete: ObjectDeletionFlag) (#1648)
-  Allow free-text annotation to have transparent border/background (#1664)

Bug Fixes (BUG)
-  Allow decryption with empty password for AlgV5 (#1663)
-  Let PdfWriter.pages return PageObject after calling `clone_document_from_reader()` (#1613)
-  Invalid font pointed during merge_resources (#1641)

Robustness (ROB)
-  Cope with invalid objects in IndirectObject.clone (#1637)
-  Improve tolerance to invalid Names/Dests (#1658)
-  Decode encoded values in get_fields (#1636)
-  Let PdfWriter.merge cope with missing "/Fields" (#1628)

[Full Changelog](3.4.1...3.5.0)
@pubpub-zz pubpub-zz deleted the iss1652 branch June 24, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

is-robustness-issue From a users perspective, this is about robustness PdfReader The PdfReader component is affected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"IndexError: list index out of range" while merging a specific PDF document

2 participants