Skip to content

ROB: Decode encoded values in get_fields#1636

Merged
MartinThoma merged 3 commits intopy-pdf:mainfrom
pubpub-zz:iss424
Feb 25, 2023
Merged

ROB: Decode encoded values in get_fields#1636
MartinThoma merged 3 commits intopy-pdf:mainfrom
pubpub-zz:iss424

Conversation

@pubpub-zz
Copy link
Collaborator

fixes #424

@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Base: 91.92% // Head: 91.88% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (719b104) compared to base (4e276b2).
Patch coverage: 57.14% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1636      +/-   ##
==========================================
- Coverage   91.92%   91.88%   -0.04%     
==========================================
  Files          33       33              
  Lines        6375     6382       +7     
  Branches     1272     1275       +3     
==========================================
+ Hits         5860     5864       +4     
- Misses        327      329       +2     
- Partials      188      189       +1     
Impacted Files Coverage Δ
pypdf/generic/_data_structures.py 90.11% <57.14%> (-0.31%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pubpub-zz
Copy link
Collaborator Author

@pubpub-zz
This PR,is all yours 😊

@MartinThoma MartinThoma changed the title ROB : Decode encoded values in get_fields ROB: Decode encoded values in get_fields Feb 25, 2023
@MartinThoma MartinThoma merged commit 2e4b657 into py-pdf:main Feb 25, 2023
MartinThoma added a commit that referenced this pull request Feb 26, 2023
New Features (ENH)
-  Add reader.attachments public interface (#1611, #1661)
-  Add PdfWriter.remove_objects_from_page(page: PageObject, to_delete: ObjectDeletionFlag) (#1648)
-  Allow free-text annotation to have transparent border/background (#1664)

Bug Fixes (BUG)
-  Allow decryption with empty password for AlgV5 (#1663)
-  Let PdfWriter.pages return PageObject after calling `clone_document_from_reader()` (#1613)
-  Invalid font pointed during merge_resources (#1641)

Robustness (ROB)
-  Cope with invalid objects in IndirectObject.clone (#1637)
-  Improve tolerance to invalid Names/Dests (#1658)
-  Decode encoded values in get_fields (#1636)
-  Let PdfWriter.merge cope with missing "/Fields" (#1628)

[Full Changelog](3.4.1...3.5.0)
@pubpub-zz pubpub-zz deleted the iss424 branch June 24, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

getFields returning '/V': {'/Filter': ['/FlateDecode']} instead of form field contents on long field

2 participants