Skip to content

BUG: Invalid font pointed during merge_resources#1641

Merged
MartinThoma merged 1 commit intopy-pdf:mainfrom
pubpub-zz:iss1640
Feb 25, 2023
Merged

BUG: Invalid font pointed during merge_resources#1641
MartinThoma merged 1 commit intopy-pdf:mainfrom
pubpub-zz:iss1640

Conversation

@pubpub-zz
Copy link
Collaborator

fixed #1640

@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Base: 91.92% // Head: 91.92% // No change to project coverage 👍

Coverage data is based on head (f5dbbe2) compared to base (4e276b2).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1641   +/-   ##
=======================================
  Coverage   91.92%   91.92%           
=======================================
  Files          33       33           
  Lines        6375     6375           
  Branches     1272     1272           
=======================================
  Hits         5860     5860           
  Misses        327      327           
  Partials      188      188           
Impacted Files Coverage Δ
pypdf/_page.py 90.54% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@raphaelm
Copy link

Can confirm it fixes the issue for me

@MartinThoma MartinThoma changed the title BUG : invalid font pointed during merge_resources BUG: Invalid font pointed during merge_resources Feb 25, 2023
@MartinThoma MartinThoma added the is-bug From a users perspective, this is a bug - a violation of the expected behavior with a compliant PDF label Feb 25, 2023
@MartinThoma MartinThoma merged commit 5173238 into py-pdf:main Feb 25, 2023
MartinThoma added a commit that referenced this pull request Feb 26, 2023
New Features (ENH)
-  Add reader.attachments public interface (#1611, #1661)
-  Add PdfWriter.remove_objects_from_page(page: PageObject, to_delete: ObjectDeletionFlag) (#1648)
-  Allow free-text annotation to have transparent border/background (#1664)

Bug Fixes (BUG)
-  Allow decryption with empty password for AlgV5 (#1663)
-  Let PdfWriter.pages return PageObject after calling `clone_document_from_reader()` (#1613)
-  Invalid font pointed during merge_resources (#1641)

Robustness (ROB)
-  Cope with invalid objects in IndirectObject.clone (#1637)
-  Improve tolerance to invalid Names/Dests (#1658)
-  Decode encoded values in get_fields (#1636)
-  Let PdfWriter.merge cope with missing "/Fields" (#1628)

[Full Changelog](3.4.1...3.5.0)
@pubpub-zz pubpub-zz deleted the iss1640 branch June 24, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

is-bug From a users perspective, this is a bug - a violation of the expected behavior with a compliant PDF

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken characters when merging pages

3 participants