Conversation
cf66543 to
d143037
Compare
|
Wouldn't this be a breaking change? |
Contributor
Author
|
Yes, this is breaking, we can note it in the changelog. |
Drop ENV vars from flags as this is non-standard in the Prometheus ecosystem. * Drop extraneous manifest.yml. Signed-off-by: SuperQ <superq@gmail.com>
d143037 to
9066633
Compare
SuperQ
added a commit
that referenced
this pull request
Feb 7, 2022
Breaking Changes: The exporter nolonger supports configuration via ENV vars. This was a non-standard feature that is not part of the Prometheus ecossystem. All configuration is now handled by the existing command line arguments. * [CHANGE] Cleanup non-standard ENV var setup #142 * [FEATURE] Add support to include ingest delay when pull metrics #129 * [FEATURE] Add monitoring.filters flag #133 * [ENHANCEMENT] Setup exporter metrics only once when we can #124 Signed-off-by: SuperQ <superq@gmail.com>
Merged
SuperQ
added a commit
that referenced
this pull request
Feb 9, 2022
Breaking Changes: The exporter nolonger supports configuration via ENV vars. This was a non-standard feature that is not part of the Prometheus ecossystem. All configuration is now handled by the existing command line arguments. * [CHANGE] Cleanup non-standard ENV var setup #142 * [FEATURE] Add support to include ingest delay when pull metrics #129 * [FEATURE] Add monitoring.filters flag #133 * [ENHANCEMENT] Setup exporter metrics only once when we can #124 Signed-off-by: SuperQ <superq@gmail.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop ENV vars from flags as this is non-standard in the Prometheus
ecosystem.
Signed-off-by: SuperQ superq@gmail.com