setup exporter metrics only once when we can#124
Merged
SuperQ merged 1 commit intoprometheus-community:masterfrom Feb 6, 2022
Merged
setup exporter metrics only once when we can#124SuperQ merged 1 commit intoprometheus-community:masterfrom
SuperQ merged 1 commit intoprometheus-community:masterfrom
Conversation
otherwise all exporter metrics will be overwritten on every scrape Signed-off-by: Fredrik Enestad <fredrik@enestad.com>
5a37940 to
92b2702
Compare
Contributor
Author
|
ping @SuperQ, would you mind take a look at this one? |
Contributor
|
Sorry, this got lost in my inbox. I think @roidelapluie did some fixes in the node_exporter in order to make things work correctly. I need to go look at the change history to try and remember what we did there to better cache things. |
SuperQ
approved these changes
Jan 31, 2022
Contributor
SuperQ
left a comment
There was a problem hiding this comment.
I think this looks mostly good. It matches the pattern we use in the node_exporter.
SuperQ
added a commit
that referenced
this pull request
Feb 7, 2022
Breaking Changes: The exporter nolonger supports configuration via ENV vars. This was a non-standard feature that is not part of the Prometheus ecossystem. All configuration is now handled by the existing command line arguments. * [CHANGE] Cleanup non-standard ENV var setup #142 * [FEATURE] Add support to include ingest delay when pull metrics #129 * [FEATURE] Add monitoring.filters flag #133 * [ENHANCEMENT] Setup exporter metrics only once when we can #124 Signed-off-by: SuperQ <superq@gmail.com>
Merged
SuperQ
added a commit
that referenced
this pull request
Feb 9, 2022
Breaking Changes: The exporter nolonger supports configuration via ENV vars. This was a non-standard feature that is not part of the Prometheus ecossystem. All configuration is now handled by the existing command line arguments. * [CHANGE] Cleanup non-standard ENV var setup #142 * [FEATURE] Add support to include ingest delay when pull metrics #129 * [FEATURE] Add monitoring.filters flag #133 * [ENHANCEMENT] Setup exporter metrics only once when we can #124 Signed-off-by: SuperQ <superq@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise all exporter metrics will be re-created on every scrape. Based on the same pattern as node_exporter.
Resolves #108, resolves #109
When using the
collectquery parameter, it will still create everything on the fly, I don't have any knowledge in how that setting is supposed to work, if that is expected behavior, or if there is still a bug there, but node_exporter seems to handle that case in the same way.