Add support to include ingest delay to pulled metrics#129
Merged
SuperQ merged 4 commits intoprometheus-community:masterfrom Feb 7, 2022
anas-aso:master
Merged
Add support to include ingest delay to pulled metrics#129SuperQ merged 4 commits intoprometheus-community:masterfrom anas-aso:master
SuperQ merged 4 commits intoprometheus-community:masterfrom
anas-aso:master
Conversation
Signed-off-by: Anas <anas-aso@users.noreply.github.com>
Signed-off-by: Anas <anas-aso@users.noreply.github.com>
Contributor
Author
|
@SuperQ can you review this PR please ? |
|
How can we progress this PR? |
Contributor
Author
|
@SuperQ did you get a chance to look at this PR? |
SuperQ
requested changes
Feb 6, 2022
Contributor
SuperQ
left a comment
There was a problem hiding this comment.
This needs a rebase and tests need to be passing.
Contributor
Author
|
@SuperQ all green now. |
SuperQ
reviewed
Feb 7, 2022
Signed-off-by: SuperQ <superq@gmail.com>
SuperQ
added a commit
that referenced
this pull request
Feb 7, 2022
Breaking Changes: The exporter nolonger supports configuration via ENV vars. This was a non-standard feature that is not part of the Prometheus ecossystem. All configuration is now handled by the existing command line arguments. * [CHANGE] Cleanup non-standard ENV var setup #142 * [FEATURE] Add support to include ingest delay when pull metrics #129 * [FEATURE] Add monitoring.filters flag #133 * [ENHANCEMENT] Setup exporter metrics only once when we can #124 Signed-off-by: SuperQ <superq@gmail.com>
Merged
SuperQ
added a commit
that referenced
this pull request
Feb 9, 2022
Breaking Changes: The exporter nolonger supports configuration via ENV vars. This was a non-standard feature that is not part of the Prometheus ecossystem. All configuration is now handled by the existing command line arguments. * [CHANGE] Cleanup non-standard ENV var setup #142 * [FEATURE] Add support to include ingest delay when pull metrics #129 * [FEATURE] Add monitoring.filters flag #133 * [ENHANCEMENT] Setup exporter metrics only once when we can #124 Signed-off-by: SuperQ <superq@gmail.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While debugging this issue #123 I found out that GCP Cloud Monitoring metrics might suffer from ingestion delay.
This PR adds support to include the ingest delay for each metric before pull it from Cloud Monitoring.