Skip to content

Storages: enhance data sharing column cache#9994

Merged
ti-chi-bot[bot] merged 7 commits intopingcap:masterfrom
Lloyd-Pottiger:optimize-column-cache
Mar 14, 2025
Merged

Storages: enhance data sharing column cache#9994
ti-chi-bot[bot] merged 7 commits intopingcap:masterfrom
Lloyd-Pottiger:optimize-column-cache

Conversation

@Lloyd-Pottiger
Copy link
Contributor

@Lloyd-Pottiger Lloyd-Pottiger commented Mar 13, 2025

What problem does this PR solve?

Issue Number: ref #6092, close #10029

Problem Summary:

What is changed and how it works?

Fix related regression caused by https://github.com/pingcap/tiflash/pull/9661

Before, one query reads pack [start, end) from disk, and add it them to cache, 
meanwhile another query also requests to read pack [start, end), then it need to copy each pack data to a new column.

Now, return the cached column directly.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 13, 2025
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
Lloyd-Pottiger and others added 3 commits March 14, 2025 10:27
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Mar 14, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, JinheLin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,JinheLin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 14, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 14, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-03-14 07:12:41.969486788 +0000 UTC m=+512717.575015714: ☑️ agreed by JaySon-Huang.
  • 2025-03-14 07:21:11.565557745 +0000 UTC m=+513227.171086670: ☑️ agreed by JinheLin.

@ti-chi-bot ti-chi-bot bot merged commit cecd973 into pingcap:master Mar 14, 2025
5 checks passed
@Lloyd-Pottiger Lloyd-Pottiger deleted the optimize-column-cache branch March 14, 2025 10:01
JaySon-Huang added a commit to ti-chi-bot/tiflash that referenced this pull request Mar 26, 2025
ref pingcap#6092

Fix related regression caused by pingcap#9661

Before, one query reads pack [start, end) from disk, and add it them to cache, 
meanwhile another query also requests to read pack [start, end), then it need to copy each pack data to a new column.

Now, return the cached column directly.

Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>

Co-authored-by: JaySon-Huang <tshent@qq.com>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-9.0-beta.1: #10037.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm needs-cherry-pick-release-9.0-beta.1 release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compared with v8.5.1, v9.0.0-beta1 olap has a 9.1% performance regression in ossinxxx-x86 workload

4 participants