Skip to content

Storages: enhance data sharing column cache (#9994)#10037

Closed
ti-chi-bot wants to merge 6 commits intopingcap:release-9.0-beta.1from
ti-chi-bot:cherry-pick-9994-to-release-9.0-beta.1
Closed

Storages: enhance data sharing column cache (#9994)#10037
ti-chi-bot wants to merge 6 commits intopingcap:release-9.0-beta.1from
ti-chi-bot:cherry-pick-9994-to-release-9.0-beta.1

Conversation

@ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #9994

What problem does this PR solve?

Issue Number: ref #6092, close #10029

Problem Summary:

What is changed and how it works?

Fix related regression caused by https://github.com/pingcap/tiflash/pull/9661

Before, one query reads pack [start, end) from disk, and add it them to cache, 
meanwhile another query also requests to read pack [start, end), then it need to copy each pack data to a new column.

Now, return the cached column directly.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

Lloyd-Pottiger and others added 6 commits March 26, 2025 08:11
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-9.0-beta.1 labels Mar 26, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 26, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign fuzhe1989 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JaySon-Huang
Copy link
Contributor

The changes are merged into #10036

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-9.0-beta.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants