Storages: enhance data sharing column cache#9661
Merged
ti-chi-bot[bot] merged 11 commits intopingcap:masterfrom Nov 27, 2024
Merged
Storages: enhance data sharing column cache#9661ti-chi-bot[bot] merged 11 commits intopingcap:masterfrom
ti-chi-bot[bot] merged 11 commits intopingcap:masterfrom
Conversation
CalvinNeo
reviewed
Nov 25, 2024
973833f to
a73fd3a
Compare
0c88dfe to
cd55680
Compare
JinheLin
reviewed
Nov 26, 2024
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
JinheLin
reviewed
Nov 26, 2024
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
JinheLin
reviewed
Nov 26, 2024
Co-authored-by: jinhelin <linjinhe33@gmail.com>
JinheLin
approved these changes
Nov 26, 2024
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
Contributor
|
Remove the duplicate code of getting data type on disk in different places: Lloyd-Pottiger#19 |
JaySon-Huang
approved these changes
Nov 27, 2024
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JaySon-Huang, JinheLin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
[LGTM Timeline notifier]Timeline:
|
12 tasks
ti-chi-bot bot
added a commit
that referenced
this pull request
Mar 14, 2025
ref #6092 Fix related regression caused by #9661 Before, one query reads pack [start, end) from disk, and add it them to cache, meanwhile another query also requests to read pack [start, end), then it need to copy each pack data to a new column. Now, return the cached column directly. Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com> Signed-off-by: JaySon-Huang <tshent@qq.com> Co-authored-by: JaySon-Huang <tshent@qq.com> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
JaySon-Huang
added a commit
to ti-chi-bot/tiflash
that referenced
this pull request
Mar 26, 2025
ref pingcap#6092 Fix related regression caused by pingcap#9661 Before, one query reads pack [start, end) from disk, and add it them to cache, meanwhile another query also requests to read pack [start, end), then it need to copy each pack data to a new column. Now, return the cached column directly. Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com> Signed-off-by: JaySon-Huang <tshent@qq.com> Co-authored-by: JaySon-Huang <tshent@qq.com> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
yongman
pushed a commit
to yongman/tiflash
that referenced
this pull request
Jun 18, 2025
pingcap#9661 Signed-off-by: Wish <breezewish@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #6092
Problem Summary:
Using
ColumnCachewhose cache entry is a pack.ColumnSharingCache's cache entry is several packs.What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note