Skip to content

Fix the incorrect value of the max thread size#9881

Merged
ti-chi-bot[bot] merged 10 commits intopingcap:masterfrom
CalvinNeo:fix-thread-pool
Feb 18, 2025
Merged

Fix the incorrect value of the max thread size#9881
ti-chi-bot[bot] merged 10 commits intopingcap:masterfrom
CalvinNeo:fix-thread-pool

Conversation

@CalvinNeo
Copy link
Member

@CalvinNeo CalvinNeo commented Feb 17, 2025 •
edited by JaySon-Huang
Loading

What problem does this PR solve?

Issue Number: close #9880, ref #9745

Problem Summary:

See the issue. We make setAuto not static as a workaround. However, we have to handle the coupling of Proxy and Settings.h.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@CalvinNeo
fix
e60b786 
Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/needs-triage-completed and removed do-not-merge/needs-linked-issue labels Feb 17, 2025
@CalvinNeo
Copy link
Member Author

CalvinNeo commented Feb 17, 2025

/cc @JaySon-Huang @windtalker @JinheLin @Lloyd-Pottiger

@CalvinNeo
f
b41d5de 
Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>
@CalvinNeo
Copy link
Member Author

CalvinNeo commented Feb 17, 2025

/check-issue-triage-complete

@CalvinNeo
f
96e653f 
Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 17, 2025
@CalvinNeo
fix
d43746c 
Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>
@CalvinNeo
test
702a39d 
Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 17, 2025
@CalvinNeo
Copy link
Member Author

CalvinNeo commented Feb 17, 2025

/check-issue-triage-complete

@JaySon-Huang
Format files
19318cb 
Signed-off-by: JaySon-Huang <tshent@qq.com>
@JaySon-Huang
Only reset the max_threads when it is decided by auto
1ff9bc6 
Signed-off-by: JaySon-Huang <tshent@qq.com>
@JaySon-Huang
Format files
7f020cc 
Signed-off-by: JaySon-Huang <tshent@qq.com>
JaySon-Huang
JaySon-Huang approved these changes Feb 17, 2025
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Feb 17, 2025
@CalvinNeo CalvinNeo changed the title Fix the incorrect value of the thread pool size Fix the incorrect value of the max thread size Feb 17, 2025
@CalvinNeo
Copy link
Member Author

CalvinNeo commented Feb 17, 2025

/hold found some problems to address tommorrow

@CalvinNeo
Copy link
Member Author

CalvinNeo commented Feb 17, 2025

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 17, 2025
windtalker
windtalker approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, windtalker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,windtalker]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 18, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 18, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-17 16:09:25.076115734 +0000 UTC m=+891207.472337792: ☑️ agreed by JaySon-Huang.
  • 2025-02-18 01:22:57.833292374 +0000 UTC m=+924420.229514421: ☑️ agreed by windtalker.

@ti-chi-bot ti-chi-bot bot merged commit ab5a517 into pingcap:master Feb 18, 2025
5 checks passed
@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. labels Feb 18, 2025
ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Feb 18, 2025
@CalvinNeo @ti-chi-bot
This is an automated cherry-pick of pingcap#9881
4c5fce8 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 18, 2025

In response to a cherrypick label: new pull request created to branch release-8.1: #9882.
But this PR has conflicts, please resolve them!

@ti-chi-bot ti-chi-bot mentioned this pull request Feb 18, 2025
Merged
12 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Feb 18, 2025
@CalvinNeo @ti-chi-bot
This is an automated cherry-pick of pingcap#9881
40c9e3f 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 18, 2025

In response to a cherrypick label: new pull request created to branch release-7.5: #9883.
But this PR has conflicts, please resolve them!

@ti-chi-bot ti-chi-bot mentioned this pull request Feb 18, 2025
Merged
12 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 18, 2025

In response to a cherrypick label: new pull request created to branch release-7.1: #9884.
But this PR has conflicts, please resolve them!

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Feb 18, 2025
@CalvinNeo @ti-chi-bot
This is an automated cherry-pick of pingcap#9881
6d14e1d 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 18, 2025
Merged
12 tasks
@CalvinNeo
Copy link
Member Author

CalvinNeo commented Feb 18, 2025

/cherry-pick release-8.5

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Feb 18, 2025
@CalvinNeo @ti-chi-bot
This is an automated cherry-pick of pingcap#9881
9d8daba 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 18, 2025

@CalvinNeo: new pull request created to branch release-8.5: #9885.
But this PR has conflicts, please resolve them!

Details

In response to this:

/cherry-pick release-8.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Feb 18, 2025
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Feb 18, 2025
@ti-chi-bot @CalvinNeo @JaySon-Huang
Fix the incorrect value of the max thread size (#9881) (#9885)
da56570 
ref #9745, close #9880

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>

Co-authored-by: Calvin Neo <CalvinNeo@users.noreply.github.com>
Co-authored-by: Calvin Neo <calvinneo1995@gmail.com>
Co-authored-by: JaySon-Huang <tshent@qq.com>
ti-chi-bot bot pushed a commit that referenced this pull request Feb 18, 2025
@ti-chi-bot @CalvinNeo @JaySon-Huang
Fix the incorrect value of the max thread size (#9881) (#9882)
bdb33ae 
ref #9745, close #9880

Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>

Co-authored-by: Calvin Neo <calvinneo1995@gmail.com>
Co-authored-by: JaySon-Huang <tshent@qq.com>
ti-chi-bot bot pushed a commit that referenced this pull request Feb 19, 2025
@ti-chi-bot @JaySon-Huang @CalvinNeo
Fix the incorrect value of the max thread size (#9881) (#9883)
4d137a0 
ref #9745, close #9880

Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>

Co-authored-by: JaySon-Huang <tshent@qq.com>
Co-authored-by: Calvin Neo <calvinneo1995@gmail.com>
ti-chi-bot bot pushed a commit that referenced this pull request Feb 24, 2025
@ti-chi-bot @CalvinNeo
Fix the incorrect value of the max thread size (#9881) (#9884)
8084e4d 
ref #9745, close #9880

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>

Co-authored-by: Calvin Neo <CalvinNeo@users.noreply.github.com>
Co-authored-by: Calvin Neo <calvinneo1995@gmail.com>
JaySon-Huang added a commit to JaySon-Huang/tiflash that referenced this pull request Apr 25, 2025
@ti-chi-bot @CalvinNeo @JaySon-Huang
Fix the incorrect value of the max thread size (pingcap#9881) (pingca…
dbf3e4c 
…p#9882)

ref pingcap#9745, close pingcap#9880

Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>

Co-authored-by: Calvin Neo <calvinneo1995@gmail.com>
Co-authored-by: JaySon-Huang <tshent@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@windtalker windtalker windtalker approved these changes

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@JinheLin JinheLin Awaiting requested review from JinheLin

@Lloyd-Pottiger Lloyd-Pottiger Awaiting requested review from Lloyd-Pottiger

Assignees

No one assigned

Labels

approved lgtm needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TiFlash's max thread is not set to correct value

4 participants

@CalvinNeo @ti-chi-bot @windtalker @JaySon-Huang