Fix the incorrect value of the max thread size (#9881)#9883
Merged
ti-chi-bot[bot] merged 6 commits intopingcap:release-7.5from Feb 19, 2025
Merged
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
12 tasks
Member
Author
|
@CalvinNeo This PR has conflicts, I have hold it. |
0ae5540 to
4c8ed1b
Compare
Signed-off-by: JaySon-Huang <tshent@qq.com>
| * settings, available functions, data types, aggregate functions, databases... | ||
| */ | ||
| global_context = Context::createGlobal(); | ||
| global_context->setApplicationType(Context::ApplicationType::SERVER); |
Contributor
There was a problem hiding this comment.
This line should be set at global Context created. We missed to move this line in the previous PR.
Related changes on the master: #9886
Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Contributor
|
/unhold |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CalvinNeo, JaySon-Huang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
[LGTM Timeline notifier]Timeline:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #9881
What problem does this PR solve?
Issue Number: close #9880, ref #9745
Problem Summary:
See the issue. We make
setAutonot static as a workaround. However, we have to handle the coupling of Proxy and Settings.h.What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note