*: Set ApplicationType and disagg param when GlobalContext created#9886
Merged
ti-chi-bot[bot] merged 5 commits intopingcap:masterfrom Feb 19, 2025
Merged
*: Set ApplicationType and disagg param when GlobalContext created#9886ti-chi-bot[bot] merged 5 commits intopingcap:masterfrom
ti-chi-bot[bot] merged 5 commits intopingcap:masterfrom
Conversation
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
This was referenced Feb 18, 2025
Contributor
Author
|
/test pull-unit-test |
Lloyd-Pottiger
approved these changes
Feb 19, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CalvinNeo, Lloyd-Pottiger The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
[LGTM Timeline notifier]Timeline:
|
ti-chi-bot
pushed a commit
to ti-chi-bot/tiflash
that referenced
this pull request
Feb 19, 2025
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Member
|
In response to a cherrypick label: new pull request created to branch |
yongman
pushed a commit
to yongman/tiflash
that referenced
this pull request
Jun 18, 2025
…ingcap#9886) (pingcap#9890) ref pingcap#9857 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> Signed-off-by: JaySon-Huang <tshent@qq.com> Co-authored-by: JaySon <tshent@qq.com> Co-authored-by: JaySon-Huang <tshent@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #9857
Problem Summary: After #9753, the code that set "application_type" and "disagg" params is far away from
Context::createGlobal(). This could lead to unexpected behavior in later code changes.Context::checkIsConfigLoadedrely oncontext->application_typebeing set correctlyWhat is changed and how it works?
The application type should be set when GlobalContext created.
Check List
Tests
Side effects
Documentation
Release note