Skip to content

Fix the incorrect value of the max thread size (#9881)#9884

Merged
ti-chi-bot[bot] merged 4 commits intopingcap:release-7.1from
ti-chi-bot:cherry-pick-9881-to-release-7.1
Feb 24, 2025
Merged

Fix the incorrect value of the max thread size (#9881)#9884
ti-chi-bot[bot] merged 4 commits intopingcap:release-7.1from
ti-chi-bot:cherry-pick-9881-to-release-7.1

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Feb 18, 2025

This is an automated cherry-pick of #9881

What problem does this PR solve?

Issue Number: close #9880, ref #9745

Problem Summary:

See the issue. We make setAuto not static as a workaround. However, we have to handle the coupling of Proxy and Settings.h.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@CalvinNeo @ti-chi-bot
This is an automated cherry-pick of pingcap#9881
6d14e1d 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Feb 18, 2025
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 18, 2025
Merged
12 tasks
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Feb 18, 2025

@CalvinNeo This PR has conflicts, I have hold it.
Please resolve them or ask others to resolve them, then comment /unhold to remove the hold label.

@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 18, 2025
@CalvinNeo
fix cp
77cf452 
Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 24, 2025
@CalvinNeo
fmt
aebf0d2 
Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>
CalvinNeo
CalvinNeo reviewed Feb 24, 2025
View reviewed changes
dbms/src/Storages/KVStore/ProxyStateMachine.h
@@ -0,0 +1,82 @@
// Copyright 2025 PingCAP, Inc.
Copy link
Member

@CalvinNeo CalvinNeo Feb 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just add it under KVStore/ temporarily.
KVStore in this version is not a static lib.
Or move it under Transaction? What do you think? @JaySon-Huang

Copy link
Contributor

@JaySon-Huang JaySon-Huang Feb 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep this file under KVStore in the branch <= 7.1 is OK to me.

@CalvinNeo
Copy link
Member

CalvinNeo commented Feb 24, 2025

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 24, 2025
CalvinNeo
CalvinNeo approved these changes Feb 24, 2025
View reviewed changes
Copy link
Member

@CalvinNeo CalvinNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Feb 24, 2025
@CalvinNeo
fiox
d79325b 
Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>
JaySon-Huang
JaySon-Huang approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the lgtm label Feb 24, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CalvinNeo, JaySon-Huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [CalvinNeo,JaySon-Huang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 24, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 24, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-24 04:32:57.329303821 +0000 UTC m=+243925.282462087: ☑️ agreed by CalvinNeo.
  • 2025-02-24 05:48:00.080541224 +0000 UTC m=+248428.033699489: ☑️ agreed by JaySon-Huang.

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Feb 24, 2025
@ti-chi-bot ti-chi-bot bot merged commit 8084e4d into pingcap:release-7.1 Feb 24, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@CalvinNeo CalvinNeo CalvinNeo approved these changes

Assignees

@CalvinNeo CalvinNeo

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ti-chi-bot @CalvinNeo @JaySon-Huang