Skip to content

join be aware of cancel signal#9450

Merged
ti-chi-bot[bot] merged 5 commits intopingcap:masterfrom
windtalker:cancel_join
Sep 21, 2024
Merged

join be aware of cancel signal#9450
ti-chi-bot[bot] merged 5 commits intopingcap:masterfrom
windtalker:cancel_join

Conversation

@windtalker
Copy link
Contributor

@windtalker windtalker commented Sep 20, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #9430

Problem Summary:

What is changed and how it works?

Check cancel signal inside join

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Cancel a query with a cross join

mysql> select count(*) from t1;
+----------+
| count(*) |
+----------+
|  8000392 |
+----------+
mysql> explain select count(*) from t1 where id not in (select id from t1);
+------------------------------------------+------------+--------------+---------------+-----------------------------------------------------------------+
| id                                       | estRows    | task         | access object | operator info                                                   |
+------------------------------------------+------------+--------------+---------------+-----------------------------------------------------------------+
| HashAgg_35                               | 1.00       | root         |               | funcs:count(Column#8)->Column#7                                 |
| └─TableReader_37                         | 1.00       | root         |               | MppVersion: 2, data:ExchangeSender_36                           |
|   └─ExchangeSender_36                    | 1.00       | mpp[tiflash] |               | ExchangeType: PassThrough                                       |
|     └─HashAgg_13                         | 1.00       | mpp[tiflash] |               | funcs:count(1)->Column#8                                        |
|       └─HashJoin_34                      | 6400313.60 | mpp[tiflash] |               | CARTESIAN anti semi join, other cond:eq(test.t1.id, test.t1.id) |
|         ├─ExchangeReceiver_21(Build)     | 8000392.00 | mpp[tiflash] |               |                                                                 |
|         │ └─ExchangeSender_20            | 8000392.00 | mpp[tiflash] |               | ExchangeType: Broadcast, Compression: FAST                      |
|         │   └─TableFullScan_19           | 8000392.00 | mpp[tiflash] | table:t1      | keep order:false                                                |
|         └─TableFullScan_18(Probe)        | 8000392.00 | mpp[tiflash] | table:t1      | keep order:false                                                |
+------------------------------------------+------------+--------------+---------------+-----------------------------------------------------------------+

Before this pr
屏幕截图 2024-09-20 165644

After this pr
屏幕截图 2024-09-20 170114

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

fix bug that join can not be cancelled timely.

@windtalker
save work
1eb2391 
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 20, 2024
gengliqi
gengliqi approved these changes Sep 20, 2024
View reviewed changes
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 20, 2024
@windtalker @gengliqi
Update dbms/src/Interpreters/Join.cpp
80854ba 
Co-authored-by: Liqi Geng <gengliqiii@gmail.com>
yibin87
yibin87 approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@yibin87 yibin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gengliqi, yibin87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 20, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 20, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-20 09:14:12.181160065 +0000 UTC m=+1211721.921584003: ☑️ agreed by gengliqi.
  • 2024-09-20 09:43:26.360857573 +0000 UTC m=+1213476.101281512: ☑️ agreed by yibin87.

@windtalker
Copy link
Contributor Author

windtalker commented Sep 20, 2024

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 20, 2024
windtalker and others added 3 commits September 20, 2024 19:11
@windtalker
use context cancel in pull model
e5e8b3c 
Signed-off-by: xufei <xufei@pingcap.com>
@windtalker
fix
bade44a 
Signed-off-by: xufei <xufei@pingcap.com>
@windtalker
fix
215b177 
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
@windtalker
Copy link
Contributor Author

windtalker commented Sep 21, 2024

/hold cancel

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 21, 2024
@ti-chi-bot ti-chi-bot bot merged commit 8aba9f0 into pingcap:master Sep 21, 2024
@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. labels Sep 21, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Sep 21, 2024
@windtalker @ti-chi-bot
This is an automated cherry-pick of pingcap#9450
8e9afab 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 21, 2024

In response to a cherrypick label: new pull request created to branch release-8.1: #9452.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 21, 2024
Merged
12 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 21, 2024

In response to a cherrypick label: new pull request created to branch release-7.5: #9453.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Sep 21, 2024
@windtalker @ti-chi-bot
This is an automated cherry-pick of pingcap#9450
44b7c81 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 21, 2024
Merged
12 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Sep 21, 2024
@windtalker @ti-chi-bot
This is an automated cherry-pick of pingcap#9450
5a5f94e 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 21, 2024

In response to a cherrypick label: new pull request created to branch release-7.1: #9454.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 21, 2024
Merged
12 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Sep 21, 2024
@windtalker @ti-chi-bot
This is an automated cherry-pick of pingcap#9450
a9488da 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 21, 2024

In response to a cherrypick label: new pull request created to branch release-6.5: #9455.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 21, 2024
Closed
12 tasks
@windtalker windtalker deleted the cancel_join branch September 21, 2024 08:22
ti-chi-bot bot pushed a commit that referenced this pull request Sep 26, 2024
@ti-chi-bot @windtalker
join be aware of cancel signal (#9450) (#9453)
2faf287 
close #9430

Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>

Co-authored-by: xufei <xufeixw@mail.ustc.edu.cn>
ti-chi-bot bot added a commit that referenced this pull request Sep 27, 2024
@ti-chi-bot @windtalker @ti-chi-bot
join be aware of cancel signal (#9450) (#9452)
a2a4c88 
close #9430

Co-authored-by: xufei <xufei@pingcap.com>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
ti-chi-bot bot added a commit that referenced this pull request Nov 1, 2024
@ti-chi-bot @windtalker @ti-chi-bot
join be aware of cancel signal (#9450) (#9454)
1d5458b 
close #9430

Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>

Co-authored-by: xufei <xufei@pingcap.com>
Co-authored-by: xufei <xufeixw@mail.ustc.edu.cn>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@ti-chi-bot ti-chi-bot bot removed the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yibin87 yibin87 yibin87 approved these changes

@gengliqi gengliqi gengliqi approved these changes

Assignees

No one assigned

Labels

approved lgtm needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

join should be aware of cancel signal

4 participants

@windtalker @ti-chi-bot @yibin87 @gengliqi