Skip to content

join be aware of cancel signal (#9450)#9454

Merged
ti-chi-bot[bot] merged 16 commits intopingcap:release-7.1from
ti-chi-bot:cherry-pick-9450-to-release-7.1
Nov 1, 2024
Merged

join be aware of cancel signal (#9450)#9454
ti-chi-bot[bot] merged 16 commits intopingcap:release-7.1from
ti-chi-bot:cherry-pick-9450-to-release-7.1

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Sep 21, 2024

This is an automated cherry-pick of #9450

What problem does this PR solve?

Issue Number: close #9430

Problem Summary:

What is changed and how it works?

Check cancel signal inside join

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Cancel a query with a cross join

mysql> select count(*) from t1;
+----------+
| count(*) |
+----------+
|  8000392 |
+----------+
mysql> explain select count(*) from t1 where id not in (select id from t1);
+------------------------------------------+------------+--------------+---------------+-----------------------------------------------------------------+
| id                                       | estRows    | task         | access object | operator info                                                   |
+------------------------------------------+------------+--------------+---------------+-----------------------------------------------------------------+
| HashAgg_35                               | 1.00       | root         |               | funcs:count(Column#8)->Column#7                                 |
| └─TableReader_37                         | 1.00       | root         |               | MppVersion: 2, data:ExchangeSender_36                           |
|   └─ExchangeSender_36                    | 1.00       | mpp[tiflash] |               | ExchangeType: PassThrough                                       |
|     └─HashAgg_13                         | 1.00       | mpp[tiflash] |               | funcs:count(1)->Column#8                                        |
|       └─HashJoin_34                      | 6400313.60 | mpp[tiflash] |               | CARTESIAN anti semi join, other cond:eq(test.t1.id, test.t1.id) |
|         ├─ExchangeReceiver_21(Build)     | 8000392.00 | mpp[tiflash] |               |                                                                 |
|         │ └─ExchangeSender_20            | 8000392.00 | mpp[tiflash] |               | ExchangeType: Broadcast, Compression: FAST                      |
|         │   └─TableFullScan_19           | 8000392.00 | mpp[tiflash] | table:t1      | keep order:false                                                |
|         └─TableFullScan_18(Probe)        | 8000392.00 | mpp[tiflash] | table:t1      | keep order:false                                                |
+------------------------------------------+------------+--------------+---------------+-----------------------------------------------------------------+

Before this pr
屏幕截图 2024-09-20 165644

After this pr
屏幕截图 2024-09-20 170114

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

fix bug that join can not be cancelled timely.

@windtalker @ti-chi-bot
This is an automated cherry-pick of pingcap#9450
5a5f94e 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Sep 21, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 21, 2024
Merged
12 tasks
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 21, 2024
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 26, 2024
windtalker
windtalker reviewed Sep 26, 2024
View reviewed changes
windtalker and others added 2 commits September 26, 2024 10:32
@windtalker
Update dbms/src/Interpreters/Context.h
cf3329a
@windtalker
resolve conflict
5667b2b 
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
@ti-chi-bot ti-chi-bot bot removed the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 26, 2024
@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 26, 2024
windtalker
windtalker approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Oct 31, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gengliqi, windtalker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [gengliqi,windtalker]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 31, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 31, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-31 08:36:58.444995194 +0000 UTC m=+511731.284150734: ☑️ agreed by windtalker.
  • 2024-10-31 08:49:22.405879305 +0000 UTC m=+512475.245034846: ☑️ agreed by gengliqi.

@windtalker windtalker mentioned this pull request Oct 31, 2024
Closed
12 tasks
@windtalker
Copy link
Contributor

windtalker commented Oct 31, 2024

/run-all-tests

1 similar comment
@windtalker
Copy link
Contributor

windtalker commented Oct 31, 2024

/run-all-tests

@purelind
Copy link
Contributor

purelind commented Nov 1, 2024

/retest

@windtalker
Copy link
Contributor

windtalker commented Nov 1, 2024

/test pull-integration-test

@ti-chi-bot ti-chi-bot bot merged commit 1d5458b into pingcap:release-7.1 Nov 1, 2024
@windtalker
Copy link
Contributor

windtalker commented Nov 1, 2024

/test pull-integration-test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@windtalker windtalker windtalker approved these changes

@gengliqi gengliqi gengliqi approved these changes

Assignees

@windtalker windtalker

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ti-chi-bot @windtalker @purelind @gengliqi