Skip to content

join be aware of cancel signal (#9450)#9455

Closed
ti-chi-bot wants to merge 1 commit intopingcap:release-6.5from
ti-chi-bot:cherry-pick-9450-to-release-6.5
Closed

join be aware of cancel signal (#9450)#9455
ti-chi-bot wants to merge 1 commit intopingcap:release-6.5from
ti-chi-bot:cherry-pick-9450-to-release-6.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Sep 21, 2024

This is an automated cherry-pick of #9450

What problem does this PR solve?

Issue Number: close #9430

Problem Summary:

What is changed and how it works?

Check cancel signal inside join

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Cancel a query with a cross join

mysql> select count(*) from t1;
+----------+
| count(*) |
+----------+
|  8000392 |
+----------+
mysql> explain select count(*) from t1 where id not in (select id from t1);
+------------------------------------------+------------+--------------+---------------+-----------------------------------------------------------------+
| id                                       | estRows    | task         | access object | operator info                                                   |
+------------------------------------------+------------+--------------+---------------+-----------------------------------------------------------------+
| HashAgg_35                               | 1.00       | root         |               | funcs:count(Column#8)->Column#7                                 |
| └─TableReader_37                         | 1.00       | root         |               | MppVersion: 2, data:ExchangeSender_36                           |
|   └─ExchangeSender_36                    | 1.00       | mpp[tiflash] |               | ExchangeType: PassThrough                                       |
|     └─HashAgg_13                         | 1.00       | mpp[tiflash] |               | funcs:count(1)->Column#8                                        |
|       └─HashJoin_34                      | 6400313.60 | mpp[tiflash] |               | CARTESIAN anti semi join, other cond:eq(test.t1.id, test.t1.id) |
|         ├─ExchangeReceiver_21(Build)     | 8000392.00 | mpp[tiflash] |               |                                                                 |
|         │ └─ExchangeSender_20            | 8000392.00 | mpp[tiflash] |               | ExchangeType: Broadcast, Compression: FAST                      |
|         │   └─TableFullScan_19           | 8000392.00 | mpp[tiflash] | table:t1      | keep order:false                                                |
|         └─TableFullScan_18(Probe)        | 8000392.00 | mpp[tiflash] | table:t1      | keep order:false                                                |
+------------------------------------------+------------+--------------+---------------+-----------------------------------------------------------------+

Before this pr
屏幕截图 2024-09-20 165644

After this pr
屏幕截图 2024-09-20 170114

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

fix bug that join can not be cancelled timely.

@windtalker @ti-chi-bot
This is an automated cherry-pick of pingcap#9450
a9488da 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Sep 21, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 21, 2024
Merged
12 tasks
@ti-chi-bot ti-chi-bot bot added the cherry-pick-approved Cherry pick PR approved by release team. label Sep 21, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 21, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign flowbehappy for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 21, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 17, 2024

@ti-chi-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-integration-test a9488da link true /test pull-integration-test
pull-unit-test a9488da link true /test pull-unit-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot removed the cherry-pick-approved Cherry pick PR approved by release team. label Jan 26, 2025
@ti-chi-bot ti-chi-bot closed this Jan 26, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 26, 2025

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@windtalker windtalker

Labels

do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ti-chi-bot @windtalker